Hey guys, shall we create some github issues focus...

# koin

[Pedro Francisco de Sousa Neto]

Hey guys, shall we create some github issues focused in increasing unit test coverage using label hacktoberfest? blob smile happy

[arnaud.giuliani]

on android side, there is the app sandbox

[arnaud.giuliani]

feel free to submit PR of course 👍

[Pedro Francisco de Sousa Neto]

app sandbox?

[arnaud.giuliani]

the ’example” apps of Koin, where many usecases are tested

[arnaud.giuliani]

if you have PR fpr hacktoberfest , ping me here on slack 👍

[Pedro Francisco de Sousa Neto]

Nice!

[Pedro Francisco de Sousa Neto]

I’ve created the issue and start working on PR right now. 🙂

https://github.com/InsertKoinIO/koin/issues/1451

[arnaud.giuliani]

ok good 🙂

[Pedro Francisco de Sousa Neto]

To create unit tests for classes that have android import like context and others it'll be required usage of Robolectric test library. In this cases it's interesting skip these classes and think in cover these classes in future or add Robolectric and continue unit test coverage?

[Pedro Francisco de Sousa Neto]

Until now, I didn’t added Robolectric but I added mockk because it’s more easy to work then Mockito. 🙃

[arnaud.giuliani]

Until now, I didn’t added Robolectric but I added mockk because it’s more easy to work then Mockito. 🙃

clearly my approach too

[Pedro Francisco de Sousa Neto]

Work in progresso 😁

[arnaud.giuliani]

Robolectric and continue unit test coverage?

yes, need to be investigated more later. But for now, mockk can help mockign tests

[Pedro Francisco de Sousa Neto]

I can’t increase unit test coverage anymore without add Robolectric (and more complexity in the project) to handle classes and functions that is working with Android classes such as Fragment and Activity.

Said that, I think I ended the proposal of increase unit test coverage in koin-android module.

Of course, any change or suggestion is welcome.

So I am officially submitting my PR. blob smile happy

[Pedro Francisco de Sousa Neto]

@arnaud.giuliani now I’ve the issue and PR waiting your code review 😁. Please don’t forget the hacktoberfest label. 🙃


https://kotlinlang.slack.com/archives/C67HDJZ2N/p1665074684308939?thread_ts=1665021743.585639&cid=C67HDJZ2N

[arnaud.giuliani]

Yep, got it. Let mer get some time to review. Many thanks for your contribution 🙏