Hello, I have had this PR open for a while and I r...
# arrow-contributors
g
Hello, I have had this PR open for a while and I really want to close it but I want some input. The current implementation might not be optimal but it does preserve the laziness of the sequence and the one I provided actually breaks that. I thought about this quite a bit and I feel like the best choice is to replace the
flatMap
with a
filter
, if that provides any benefits at all. I'd love to hear your thoughts https://github.com/arrow-kt/arrow/pull/2818
s
Hey @Giorgos Makris, Sorry for the inactivity. I am replying on the PR directly. This signature cannot exist whilst preserving laziness by definition. If you lazily compute
Either
, then there is no way to return
Pair<Sequence<Either<_, _>, Sequence<Either<_,_>>>_
without computing all the results first. Let's discuss further in the PR. Thanks for bringing this up here again 👍
g
The inactivity was my fault, no need to be sorry!