Would it be possible to add a flag to allow us to ...
# apollo-kotlin
s
Would it be possible to add a flag to allow us to treat
UnusedVariable
as an error issue instead of just warning? I can file a github issue about this if folks feel it would be useful/make sense.
s
I think the issue is that we have some deprecation warnings that we don’t want to fail on
m
I see
What we really need is a way to set the level per-issue type
s
Yeah. A list of warnings to fail on, perhaps?
m
I think we might as well go all in on configurability
s
Ok, I lied. It looks like the deprecation warnings are gone for us… For our current use-case it does look like
failOnWarnings
would do the job.
homer disappear
m
Nice!
At some point, we'll probably need something like this though:
Copy code
{ 
  issue: UnusedVariable,
  level: Error,
},
{ 
  issue: UnusedFragment,
  level: Warning,
},
{ 
  issue: DeprecatedUsage,
  level: Ignore,
},
Feel free to open an issue, at least for tracking
And then we need baselines 🙈
s
Oof, yeah…
Ok!I will put up an issue.
❤️ 1
w
And then we need baselines
Do you? I mean it would be nice, but it wouldn't necessarily block the per-issue configuration I think. At least I know of one high-profile project which added such configuration but doesn't have baselines support https://kotlinlang.org/docs/whatsnew-eap.html#how-to-apply 😏
🤩 1
👍 1
s