Hey, I'm running into issues while deployment when...
# http4k
d
Hey, I'm running into issues while deployment when using
helidon
as server. In my service I have multiple calls to upstream services (using
okhttp
). But during deployment in k8s I'm facing that
helidon
will kill all running requests (
Closed by interrupt
) even when I sleep first in my shutdown hook. So far I understand
helidon
has it's own shutdown hook registered by default. Would be nice to support in addition graceful stopmode to overcome that kind of issue.
Created a PR for that, but not sure about potential missing tests? Any opinions? https://github.com/http4k/http4k/pull/1364
d
Happy to add it. There is a test for graceful shutdown test that needs updating as well:
Copy code
class HelidonStopTest : ServerStopContract(Helidon, JettyClient(), {
    enableImmediateStop()
})
d
Thanks, wasn't aware of them - will add the graceful part 😄
Hey @dave I'm looking right now into https://github.com/http4k/http4k/pull/1364 Do you have any suggestions where to start?
gradle :http4k-server-shutdown-integration-test:integrationTests --rerun-tasks
is successful on my machine - even when changing docker limits to 4 CPUs.