What is the best place to report bugs? Here is an ...
# compose-desktopa
altavir
10/09/2022, 7:54 AMWhat is the best place to report bugs? Here is an obvious one. Without override it get guaranteed SO.
a
Arkadii Ivanov
10/09/2022, 8:17 AMI usually report here - https://github.com/JetBrains/compose-jb/issues
a
altavir
10/09/2022, 8:18 AMOK. It seems a bit too clogged.
altavir
10/09/2022, 8:21 AMAh, as I expected the problem seems to be in the upstream compose core
altavir
10/09/2022, 8:23 AMActually, while I am here. Canvas API seems to be a mess. It requires major rework.
a
Arkadii Ivanov
10/09/2022, 8:23 AMWhat is the file?
a
altavir
10/09/2022, 8:24 AMandroidx\compose\ui\graphics\drawscope\DrawScope
a
Arkadii Ivanov
10/09/2022, 8:28 AMThanks, perhaps it could be reported in buganizer - https://issuetracker.google.com/issues/new?component=1070487&template=1667231
a
altavir
10/09/2022, 8:31 AMI do not work on Android so it is hard for me to track it. I am currently doing a simple SVG backend for canvas to be able to export something. And it is clear that there are a lot of design problems in the API. I will publish the results so maybe people from Google can look at it. The problem with infinite recursion is rather minor compared to everything else.
a
Arkadii Ivanov
10/09/2022, 8:34 AMSince it's a common API, it's still primarily maintained by Google. So reporting bugs via the buganizer would be a good idea. For feedback you could also try #compose channel, there are many Googlers from Compose team there.
m
Michael Paus
10/09/2022, 1:58 PM@altavir What exactly are your complaints about the Canvas (which canvas actually. DrawScope, Canvas or native Canvas).
a
altavir
10/09/2022, 2:02 PMThe problem is that there is a lot of duplicating behavior. Canvas and DrawScope do the same thing, but use different arguments and it does not seem to be possible to reimplement only one of them. Also there is DrawContext that does not have any meaning at all. There are also parts of internal API like Matrix dangling randomly from some places.
altavir
10/09/2022, 2:06 PMSome things could not be achieved without casting a Canvas to specific type of native canvas and obviously the only native canvas hardcoded there is the skia canvas.
altavir
10/09/2022, 2:06 PMAlso Path could not be accessed without casting it to Skia path.
m
Michael Paus
10/09/2022, 2:06 PMI also had to use some SVG recently (in an app for desktop, android and ios) and found that three different parsers where needed to do that and none of them could render directly into a Compose canvas. Are you planning anything in that direction?
a
altavir
10/09/2022, 2:08 PMI've actually already done that 🙂 Adding some finishing touches right now. It does not fully support all features, but at least those that I need are working. I will finish the code today and add a link here.
m
Michael Paus
10/09/2022, 2:08 PMThat would be great.
Michael Paus
10/09/2022, 2:10 PMBy the way, did you have a look at the native Skia SVG? I now use that instead of the Batik stuff on desktop.
a
altavir
10/09/2022, 2:10 PMI took a look, but did not find it Useful. I used JFreeSVG instead.
m
Michael Paus
10/09/2022, 2:11 PMOh god, that would be the fourth one 😉🙃.
a
altavir
10/09/2022, 2:12 PMHere is the implementation: https://github.com/SciProgCentre/maps-kt/tree/main/maps-kt-scheme/src/jvmMain/kotlin/center/sciprog/maps/svg
altavir
10/09/2022, 2:12 PMSome canvas features like layers are missing, but most of it works fine.
m
Michael Paus
10/09/2022, 2:13 PMThanks, I’ll have a look.
a
altavir
10/09/2022, 2:13 PMWe can create a separate library from that. Right now I need that scheme features are working.
l
Loney Chou
10/09/2022, 4:59 PMI think DrawScope is a better functional abstraction layer wrapping Canvas that platforms use to implement the actual behavior for each Paints, and you see Canvas can be a single one that gets passed around DrawEntities while DrawScope may have plenty.
a
altavir
10/09/2022, 5:01 PMWell, in practice in order to use them, one needs to duplicate the functionality thrice: in Canvas, DrawScope and DrawContext. The latest could be delegated, but it does not really help. Also there is no way (without hacks) to implement rendering for Path. Because Path does not provide a way to read its content.
l
Loney Chou
10/09/2022, 5:06 PMI imagine one could only implement Canvas? Also yeah Path is surely an expect thing.
a
altavir
10/09/2022, 5:08 PMNo, you can't implement only canvas because DrawScope does not delegate to canvas by default. Only for some specific methods. As for Path I am not sure how it is "expected".
l
Loney Chou
10/09/2022, 5:08 PMoh that's unfortunate
Loney Chou
10/09/2022, 5:08 PMIf you mention Path then ShaderBrush is also a 😶
a
altavir
10/09/2022, 5:10 PMYes, but this does seem to be expected. Shader depend on the platform after all.
l
Loney Chou
10/09/2022, 5:11 PMMaybe google has not come up with a clean idea for Path.
Loney Chou
10/09/2022, 5:11 PMThey're not that abstract after all.
a
altavir
10/09/2022, 5:11 PMIt looks like it just requires a cleanup. It obviously was designed with single implementation in mind.
l
Loney Chou
10/09/2022, 5:19 PMLoney Chou
10/09/2022, 5:20 PMIs this still there?
a
altavir
10/09/2022, 5:21 PMDon't know. Have not worked with animations yet
l
Loney Chou
10/11/2022, 4:56 AMIs this still there?
Confirmed that this still remains unfixed. Surprised that no one gets affected.
4 Views