I know this algorithm is inefficient if the grid is densely populated, but how could this code be im...

# codereview

[Ellen Spertus]

I know this algorithm is inefficient if the grid is densely populated, but how could this code be improved without changing the algorithm?

Untitled.kt

[Klitos Kyriacou]

A do-while loop seems more appropriate to me:

var x: Int
        var y: Int
        do {
            x = Random.nextInt(0, NUM_COLS)
            y = Random.nextInt(0, NUM_ROWS)
        } while (isOccupied(x, y))
        place(entity, x, y)

[Ellen Spertus]

Thanks! I didn't realize I could declare a var without initializing it.

[Klitos Kyriacou]

You have to initialize it, but not necessarily at the point of declaration.

[ephemient]

* you have to initialize it before it is used, same as a val

val x: Int
var y: Int
if (Random.nextBoolean()) {
    return
} else {
    x = 1
    y = 2
}
// OK to use x and y here

[bezrukov]

you can write placeIfEmpty(entity, x, y) fun which returns true if the entity was added. Then use while or do-while as mentioned above. e.g:

do {
    val x = Random.nextInt(NUM_COLS)
    val y = Random.nextInt(NUM_ROWS)
} while(!placeIfEmpty(entity, x, y)

Additionally, you will avoid implicit contract "check it's not occupied before placing"

[Klitos Kyriacou]

That also reminds me that local variables inside a do-while block are visible to the while condition expression. Unlike Java.