Hello, 1.7.20-1.0.7 is <here>! A major change is that we flipped `blockOtherPlugins` on by default, ...

# ksp

[Ting-Yuan Huang]

Hello, 1.7.20-1.0.7 is here! A major change is that we flipped blockOtherPlugins on by default, meaning that other compiler plugins won't be loaded in KSP's Gradle task. This will prevent most of the unexpected interactions with other compiler plugins. Other than that there are quite a few bug fixes. Thank you for the discussion, bug reports, and pull requests!

[Paul Woitaschek]

Might that ``blockOtherPlugins`` be a reason why showkase https://github.com/airbnb/Showkase is not generating any code with 1.0.7?

[Ting-Yuan Huang]

Can you try to see if turning blockOtherPlugins back off would help? by putting a ksp { blockOtherPlugins = false } in build.gradle.kts

[Paul Woitaschek]

Yes already did and it fixes it

[Ting-Yuan Huang]

🤦 Let me investigate

[Ting-Yuan Huang]

May I ask for a test case? Or did upgrading to 1.0.7 break ./gradlew test in Showkase?

[Paul Woitaschek]

I can check next week

[Ting-Yuan Huang]

🙏

[Ting-Yuan Huang]

@Paul Woitaschek Any chance you got some time on repro steps?

[Paul Woitaschek]

I actually couldn't

[Paul Woitaschek]

(reproduce)

[Paul Woitaschek]

However in my pet project .7 broke sth:
https://github.com/PaulWoitaschek/Voice/pull/1559

[Ting-Yuan Huang]

The build failed when validating voice.data.repo.internals.Converters , which referenced some of the symbols that were brought to compile classpath by some other compiler plugins. In 1.0.7 other plugins and their dependencies are NOT included in compiler plugin classpath by default in KSP's task, and therefore they can't be found. Can you check what voice.data.repo.internals.Converters depends and add all of them into compileOnly dependencies?

[Paul Woitaschek]

The same happens. It removed more and more classes and it boils down to classes of another gradle module (the common module, i.e. BookId being referred).
The only way to fix that I found was to disable the blocking
https://github.com/PaulWoitaschek/Voice/commit/77436370a5d43c5ecbbb85643cc79f2d649b0d1e

[Ting-Yuan Huang]

Looks like kotlin-serialization shouldn't be blocked; ListSerializer (link) can't be resolved without it.

btw, the BookId cannot be validate()-ed even with other plugins unblocked. It fails to be validated because of an annotation attached by Compose can't be resolved.

[Ting-Yuan Huang]

Let me think how to fix this...

[Ting-Yuan Huang]

and thanks a lot for reporting this issue!

[Paul Woitaschek]

@Ting-Yuan Huang
I’m still facing this. Did you find a way to fix this?

[Ting-Yuan Huang]

Sorry I'm on a long leave until mid May. @Jiaxiang would you please help with this?

[Paul Woitaschek]

Found a way to fix it: instantiating the list serializer everytime inside the function. Then KSP doesn't scan it. But it's a bad solition

[Paul Woitaschek]

https://github.com/PaulWoitaschek/Voice/commit/72dce22722edd2358464cf3509f06cb89985e52b

[Paul Woitaschek]

If you add it back to a class property the issue will face up again