A modern programming language that makes developers happier.

kotlinlang

Hey there, it’s again me from Sonar.

We just upgraded to 2.2 and some of our tests started failing.

After looking deeper we realized that the comments in the middle of String concatenations are not visited due to this change:

<https://github.com/JetBrains/kotlin/commit/f33566e0d7883ca3c56d2552cc4da0cbf6ad966a|https://github.com/JetBrains/kotlin/commit/f33566e0d7883ca3c56d2552cc4da0cbf6ad966a>

I understand the reasoning behind this, however I believe that PSI was supposed to be used as full fidelity tree, implying that the default should be true.

However, just setting it to true will keep the nested KtBinaryExpressions of string concatenations in the llist, not their children. And this can lead to the stack overflow.

I’m not sure if there’s a bug there or it’s how it is supposed to be? So decided to ask here before raising anything in the Youtrack.




> After looking deeper we realized that the comments in the middle of String concatenations are not visited due to this change:
Hi! It looks like a bug, thanks. Please create an issue with reproduction (expect/actual behavior) and assign it to me.