isSystemInDarkTheme() this composable not work in desktop. i have mac os i try change mac system the...

# multiplatform

[Meet]

isSystemInDarkTheme() this composable not work in desktop. i have mac os i try change mac system theme but can not be observe change isSystemInDarkTheme(). it issue.

[Meet]

current i use this library for desktop version it work it
https://github.com/Dansoftowner/jSystemThemeDetector

[zsmb]

This is known, tracked here https://youtrack.jetbrains.com/issue/CMP-1986/isSystemInDarkTheme-should-dynamically-update-when-system-theme-is-changed

[Meet]

Ok

[אליהו הדס]

https://github.com/kdroidFilter/Platform-Tools?tab=readme-ov-file#-dark-mode-detection-module

[אליהו הדס]

I made a special module for this, you can use it directly. It is easier to use than jsystemthemedetector but above all, it does not relay on polling under Linux

[Meet]

yes thanks for sharing

[Meet]

currently i use this. but i know it not work linux . its ok

@Composable
actual fun isSystemInDarkThemeMode(): Boolean {
    val detector by remember {
        mutableStateOf(
            OsThemeDetector.getDetector()
        )
    }
    val isSupported by remember(detector) {
        derivedStateOf {
            OsThemeDetector.isSupported()
        }
    }
    val isDark by remember(detector.isDark) {
        derivedStateOf {
            detector.isDark
        }
    }
    val isSystemThemeByFoundationLib = isSystemInDarkTheme()

    var isSystemInDarkTheme by rememberSaveable(isDark,isSystemThemeByFoundationLib) {
        mutableStateOf(
            if (isSupported) {
                detector.isDark
            } else {
                isSystemThemeByFoundationLib
            }
        )
    }

    DisposableEffect(isSystemInDarkTheme) {
        val listener = Consumer<Boolean> {
            if (isSupported) {
                isSystemInDarkTheme = it
            }
        }
        detector.registerListener(listener)
        onDispose {
            detector.removeListener(listener)
        }
    }
    return isSystemInDarkTheme
}

[אליהו הדס]

Try my module, i've checked it on KDE and Gnome

[Meet]

yes i see it your code great job

[Meet]

@אליהו הדס just one suggestion in any repo try to add screenshot or video. developer atleast see it how looks like which platform work it.

[Meet]

@zsmb Thanks for sharing link

[אליהו הדס]

@Meet I should take the time to do it.