Also somewhat related, `legacy` feels weird, my cu...
# library-development
m
Also somewhat related,
legacy
feels weird, my current ABI is not "legacy", it's just a tiny bit "older" than the tip of
main
r
I believe legacy refers to it being a legacy check, not legacy abi.
m
Oh! I see, thanks!
Feels weird to have the "new" talk about "legacy" already
r
Legacy refers to a direct port of the external bcv plugin logic. They're also planning new checks that aren't ready yet. I've seen some discussion on the differences in an issue somewhere but I can't find it now
m
I would have just used the final task names now and changed the internal format down the road.
Minimize changes overall
s
Initially,
Legacy
meant "format of the dump for legacy BCV plugin with its verification rules and ABI extracting method".
I would have just used the final task names now and changed the internal format down the road.
BCV as a part of KGP now in experimental state. This means that these tasks may be changed, renamed or removed in any future release. For production projects it is recommended to continue using separate plugin until KGP API stabilization.
m
This means that these tasks may be changed
This "may" sounds more like a "will" be changed.
I'm OK with experimental status but I would have tried to make it best effort as close as possible to the final task names
At least this is my current expectation for "experimental" in the Kotlin world.
It's • This API is what we think is currently best but it might change depending on feedbacks And not • This API is temporary while we work out the internal details
Sorry for being a pain about it, it's not the end of the world and I can definitely live with this but given the tool itself is about conveying API stability semantics, I find it's an interesting discussion to have
s
This is a flaw in the current experimental API concept: everyone understands "experimental" status in their own way. We are working to change this situation somehow.
nod 1
m
Agreed, it's a lot of nuances
r
For production projects it is recommended to continue using separate plugin until KGP API stabilization.
This seems at odds with the big "Discontinued" message at the top of the external BCV github. The impression I was getting is that the external plugin is no longer getting updates and we should all be moving to the built-in one.
1
s
This seems at odds with the big "Discontinued" message at the top of the external BCV github. The impression I was getting is that the external plugin is no longer getting updates and we should all be moving to the built-in one.
Yes, the addition of new features and minor bugs has stopped, but the plugin itself is functional. And as stated below in the same message, you should continue to use it until the BCV in KGP is stabilized.
r
Ok that's fair. I think that last part wasn't there last time I looked at it.
m
I plead guilty I stopped reading at
Support for this plugin has been discontinued
😄
s
I plead guilty I stopped reading at
Support for this plugin has been discontinued
Sorry about that) It looks like the message needs to be reformulated.
m
I guess the main issue is that what is recommended for production is also what doesn't get support
If I have an issue with the plugin in production, I have nowhere to file an issue now. Unless I go try the experimental thing which is not recommended for production
The library authors audience is an educated one so it can probably navigate this but still a complex message to send
s
Is the issue related to Gradle DSL or dumps?
m
I have no issue, this is purely theorethical 😄
I mean, I have a bunch of issues that were open over the years but nothing really blocking me right now
I want to use the thing that is supported. And I also want to use it in production.
Which is not possible right now
Unless I use the experimental thing in production of course (which is what I'm doing)
s
> Which is not possible right now Is there a specific issue that prevents it from being used in production now?
m
The issue is that I can't file issues if anything comes up
I like to use tools where I know I can get help if something comes up
s
Critical bugs that interfere with the use of the separate BCV plugin in production will be fixed.
👍 1
m
Gotcha 👍
I'd recommend wording the message such as
Copy code
This plugin is in maintainance mode
kodee loving 1
s
I agree, we'll rewrite this message to a less frightening one.
❤️ 1
m
Thanks ! Maybe also replace the warning admonition with an "info" admonition or so...
And thanks for the nice discussion!
❤️ 1
s
Thank you for your feedback
kodee loving 1