Why does `gradle kotest` exit code 0 on failed tes...

# kotest

[Emre]

Why does gradle kotest exit code 0 on failed tests but gradle test correctly returns 1? Is there a setting for this? Tested on kotest 6.0.2, gradle 9.0.0.

[sam]

Probably kotest task not handling test errors as an exit

[sam]

https://github.com/kotest/kotest/blob/master/kotest-framework/kotest-framework-eng[…]c/jvmMain/java/io/kotest/engine/errors/handleEngineError.jvm.kt

[sam]

that was added to 6.0.3

[sam]

maybe throwing isn't sufficient to cause gradle to exit, I can try an exitProcess(1) like the other platforms

[sam]

ooh you tried 6.0.2

[sam]

can you try 6.0.3 ?

[Emre]

yes, sorry it was a typo

[Emre]

but I wonder if it was like that in 5.x too

[sam]

the kotest task is new

[Emre]

I was using the plugin before

[sam]

oh

[sam]

the old one

[Emre]

i suppose so; now archived

[sam]

yes

[sam]

that was moved into the main repo and overhauled

[Emre]

I think 6.0.03 does not fix it, based on a quick test.

[Emre]

Look at the exit codes below. The first one is gradle kotest , exiting with 0.

I can upload a MWE and create a ticket if it helps. This is a bug, right?

[Emre]

I also suspect kotest is not terminating properly; there are zombie processes related to the tests.

[sam]

definitely a bug

[sam]

I think just need to flip to a system exit instead of throwing an exception

[sam]

If you want to try a snapshot build I can do that now?

[Emre]

i'll revert to regular test until it is fixed in 6.0.4? after the fix I'll see if the zombies are still around.

[sam]

that would unblock you, but if its just a case of switching to System.exit I'm happy to release 6.0.4 right now

[sam]

not sure how to test it quickly

[sam]

just any failing test ?

[Emre]

any failing test I think

[Emre]

I cloned your tests repo and created a 1==2 test to trigger failure

[sam]

the kotest-examples one ?

[Emre]

yes

[sam]

works running the test task from intellij

[sam]

I see "success" at the cli (so is not doing it right)

[Emre]

nice to have a reproduction.

[sam]

yes

[sam]

tryng to fix now

[sam]

ok I got it failing

[sam]

https://github.com/kotest/kotest/pull/5080

[Emre]

p.s. 6.0.3 is not yet in GH releases

[sam]

ah thanks

[sam]

fixd