Is there any particular reason why you create copy...

# opensavvy

[Robert Jaros]

Is there any particular reason why you create copy tasks using DefaultIncrementalSyncTask class instead of standard Copy class?

[Robert Jaros]

These sync task doesn't support any custom filtering, so to implement it, I would need to change SyncTask class to standard Copy class. Would it be acceptable? As an alternative I could probably add some intermediate copy task for resources processing.

[CLOVIS]

Sadly it's not, because the standard Sync/Copy tasks are not incremental, I used them before and that's why it was always reloading all files.

[Robert Jaros]

I see. Ok, I'll try to workaround ... 🙂

[CLOVIS]

I'm ok with copy-pasting DefaultIncrementalSyncTask into the plugin and making changes to it, if that helps

[CLOVIS]

I'm going to need to do this anyway because I need it to be able to reorganize files upon copy (to fix the weird working directory we have)

[Robert Jaros]

Tried copying the class but it doesn't compile. I think some basic dependencies are missing (gradle-core-api?). But I'm not sure how to add a dependency 🙂 Everything seems to be configured by convention plugins ...

[CLOVIS]

You can edit libs.versions.toml normally, I'll clean it up later if needs be, it already helps a lot if you can make it work at all

[Robert Jaros]

It's not a classpath issue. It's some java functional interfaces interop difference with new Kotlin version? I don't follow Java interop changes very closely 😉 In general I need to change it to this in lambdas.

[CLOVIS]

I'm not aware of such difference, but I don't follow too closely either

[CLOVIS]

Is it a real problem or just IDEA being confused?

[Robert Jaros]

real, gradle compilation doesn't work as well

[CLOVIS]

maybe KGP has some bonus options I don't have

[Robert Jaros]

It works. I'll cleanup everything, fill a new issue and create a MR. Is there anything else I should pay attention to?

[CLOVIS]

I guess the commit style?

We can discuss the details together later anyway

[CLOVIS]

Just so you know, I'm giving a talk next friday, and until then my free time is very limited

[Robert Jaros]

No problem