Bumping to material3, version 1.4.0 from 1.3.2 bro...
# compose
c
Bumping to material3, version 1.4.0 from 1.3.2 broke some of my designs (buttons specifically). Did I miss a memo? Looking at the release notes I don't notice any callouts there?
k
More specifically? Size change? Paddings change? Typography change? Color change? Crashing at runtime?
c
Color change. We had out a pretty simple design system applied to m3. But not the disabled state of our
Button
is wrong, and the "on" color of our
OutlinedButton
is wrong too
k
Post snippets + before / after screenshots. This is too vague right now to be able to give concrete info.
Disabled filled buttons spec (https://m3.material.io/components/buttons/specs#c75be779-5a59-4748-98d4-e47fc888d0b1) hasn't changed in a while, and neither has the default implementation (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/[…]oidx/compose/material3/Button.kt;l=1219?q=defaultButtonColors) that fills the default colors. There's too many things here that you need to make explicit in your description - what kind of a button (filled, outline, etc), are you relying on default disabled colors or providing your own, are the colors right but incorrect alpha, etc. Guessing at these gets time consuming
c
Yeah totally understand. In this case I just wanted to know if there were some overarching changes that i missed the memo on
seems like nothing notable so i will investigate further. cheers
k
There might be an unintended regression from the work on Material 3 Expressive. That certainly touched a lot of components, including buttons.
c
Looks like I had an onVariant that was set to a variant color. And while that looked right with 1.3.2, it was wrong with 1.4.0. once i made the change of onVariant to our onVariant color then everything worked. so it seems like a mistake on my teams side in the first place, but weird that it worked in 1.3.2. so maybe a fix on the m3 side?