11th hour but I started testing the new `containin...

# compiler

[Zac Sweers]

11th hour but I started testing the new containingFileName APIs introduced to FIR in 2.3.0, and finding that it doesn't actually seem to be compatible with KGP's IC implementation 😞. Something seems to get lost in translation between how kotlinc understands this file path (which is relative/based on the package) and how KGP does (it expects an absolute path?)

KT-82809 [FIR][IC] New containingFileName parameter API is not actually compatible with IC

[Oliver.O]

I have a case where kotlinc IC trips over a relative path it generated on its own for top-level declarations in FIR.

[Zac Sweers]

Do you wanna comment with your repro in the ticket?

[Oliver.O]

Done. I also have an ongoing discussion about IC issues with Dmitriy Novozhilov and others.

[Isaac Udy]

This might be a slight tangent, but is it expected that Kotlin 2.3.0 should bring IC support for top-level declarations generated via a FirDeclarationGenerationExtension? I'm only juuust starting to play around with some compiler plugin stuff, and I may have missed some news here.

[Zac Sweers]

That’s the API we’re talking about and there was a new API added to support IC with it, yes. The work is not done in 2.3.0 but my understanding was that it should at least work for JVM in 2.3.0, with other support for remaining platforms happening in 2.3.20

[dmitriy.novozhilov]

I checked, in 2.3.20 it doesn't work even when the containingFileName is not specified.
Working on the fix.

[dmitriy.novozhilov]

It appeared that the IC test framework we've used for plugin testing doesn't go the same code passes as KGP IC does.

[Oliver.O]

Not tested yet, but 2.3.20-dev-6000 looks kinda cool. 😆 Like some fancy product series.