I'm seeing a regression in KGP 2.3.20-RC where com...

# multiplatform

[aurimas]

I'm seeing a regression in KGP 2.3.20-RC where common classpath seems to not work correctly anymore.

> Task :navigation:navigation-common:compileCommonMainKotlinMetadata FAILED
e: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavArgument.kt:19:17 Unresolved reference 'savedstate'.
e: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavArgument.kt:20:17 Unresolved reference 'savedstate'.
e: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavArgument.kt:74:54 Unresolved reference 'SavedState'.
e: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavArgument.kt:85:45 Unresolved reference 'SavedState'.

i'm seeing the failures as if androidx.savedstate was not even on the classpath but it clearly is here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-common/build.gradle;l=66

and it works just fine with KGP 2.3.10

Does this ring any bells to anyone?

[aurimas]

It seems that if I swap

api("androidx.savedstate:savedstate:1.4.0")

to

api(project(":savedstate:savedstate"))

(built from source instead of a built version in maven) it compiles as expected

[aurimas]

Narrowed this down to

2.3.10 - works

2.3.20-Beta1 - broken

[aurimas]

As far as I can tell https://packages.jetbrains.team/maven/p/kt/dev/org/jetbrains/kotlin/kotlin-gradle-plugin/ doesn't have anything else in between to narrow this down

[aurimas]

welp, this is 2054 commits

https://github.com/JetBrains/kotlin/compare/v2.3.10...v2.3.20-Beta1

[jw]

Might want to also send to #C0KLZSCHF

[aurimas]

I am printing out libraries.files on the KotlinCompileCommon task.

For 2.3.10 I get

/usr/local/google/home/aurimas/.gradle/caches/modules-2/files-2.1/androidx.arch.core/core-common/2.2.0/5e1b8b81dfd5f52c56a8d53b18ca759c19a301f3/core-common-2.2.0.jar
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.annotation-annotation-1.9.1-commonMain-WmoUwA.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.lifecycle-lifecycle-common-2.9.4-commonMain-2l5nFA.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.lifecycle-lifecycle-runtime-2.9.4-commonMain-IrcNlw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.lifecycle-lifecycle-viewmodel-2.9.4-commonMain-YZugNA.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.lifecycle-lifecycle-viewmodel-savedstate-2.9.4-commonMain-KTe1Gw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.savedstate-savedstate-1.4.0-nonAndroidMain-JkDvJw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.savedstate-savedstate-1.4.0-commonMain-JkDvJw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlin-kotlin-stdlib-2.1.20-commonMain-uBNgdg.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.collection-collection-1.5.0-commonMain-j7f1lg.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlinx-kotlinx-serialization-core-1.7.3-commonMain-s2qClw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlinx-kotlinx-coroutines-core-1.9.0-commonMain-ENDfhw.klib

but for 2.3.20-Beta01 I get

/usr/local/google/home/aurimas/.gradle/caches/modules-2/files-2.1/androidx.arch.core/core-common/2.2.0/5e1b8b81dfd5f52c56a8d53b18ca759c19a301f3/core-common-2.2.0.jar
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.annotation-annotation-1.9.1-commonMain-WmoUwA.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.lifecycle-lifecycle-viewmodel-savedstate-2.9.4-commonMain-KTe1Gw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlin-kotlin-stdlib-2.1.20-commonMain-uBNgdg.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/androidx.collection-collection-1.5.0-commonMain-j7f1lg.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlinx-kotlinx-serialization-core-1.7.3-commonMain-s2qClw.klib
/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/out/navigation-playground/navigation/navigation-common/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlinx-kotlinx-coroutines-core-1.9.0-commonMain-ENDfhw.klib

somehow libraries are not being set anymore

[aurimas]

This really smells like a regression

[aurimas]

so far no luck creating a standalone repro

[tapchicoma]

cc @Margarita Bobova @Anton Lakotka [JB]

[Anton Lakotka [JB]]

Yes-yes we're aware

[aurimas]

For posterity, this is tracked in https://youtrack.jetbrains.com/issue/KT-84533