We are using kotlin test in some places and I'm tr...

# test

[Eugen Martynov]

We are using kotlin test in some places and I'm trying to chain some calls. Is it correct usage?

with(assertIs<HomeFeedResult.Error>(repository.fetchHomePageFeedsMetaData(10))) {
            with(assertIs<HomeFeedException.ServerError>(exception)) {
                assertEquals(404, code)
                assertTrue(message.orEmpty().contains("Server error 404"))
            }
        }

Looks a bit hard to read and assertK is doing it in a better way.

[Javier]

val foo: Foo = …
with(foo) { … }

[CLOVIS]

You don't need to group everything like that

val metadata = repository.fetchHomePageFeedsMetaData(10)
assertIs<HomeFeedResult.Error>(metadata)
val exception = assertIs<HomeFeedException.ServerError>(metadata.exception)
assertEquals(404, exception.code)
assertTrue(exception.message.orEmpty().contains("Server error 404"))

[CLOVIS]

IMO simpler code is easier to read, the nesting doesn't help much here

[Eugen Martynov]

Then you get compiler warnings that assertIs result is not used

[Eugen Martynov]

Sorry missed that part here

[CLOVIS]

Ah, they forgot the @IgnorableReturnValue

[CLOVIS]

Reported: KT-85068 Kotlin-test: assertIs is missing @IgnorableReturnValue

[CLOVIS]

assertIs smart-casts the value so you shouldn't have to create a variable, you can use your existing one

[Eugen Martynov]

Thanks!