Feel free to give feedback :pray:
# koin
a
Feel free to give feedback 🙏
e
I wonder how it counts legacy DSL. I have next construction
Copy code
inline fun <reified T : Any> Module.retrofitApiOf(qualifier: Qualifier? = null): KoinDefinition<T> = factory<T>(qualifier) {
    get<Retrofit>(named("GENERIC"))
        .create(T::class.java)
}
And next piece is failing
Copy code
retrofitApiOf<AddressBookApi>()
        factory { AddressBookService(get<AddressBookApi>(), get<DispatcherProvider>()) }
With
[Koin][KOIN-D003] Missing definition: addressbook.shared.data.AddressBookApi
a
yes, generics + extensions 😅
e
Since old dsl now also compile time checked (not looking for the bug above) - what is motivation to move to new dsl now?
a
safer compile safety (we have more corner case in old dsl), and code is generated for you.
e
Would be great to quantify safety corner cases
a
yep, will need to rework some docs 😅
thank you color 1
m
Hi 👋 I'm bumping the memory leak in koin-compiler-plugin 1.2.1: https://github.com/InsertKoinIO/koin-compiler-plugin/issues/110 This is blocking our move to Kotlin 2.4.20. 1.1.0 doesn't support 2.4.20, and 1.2.1 can't build the project due to OOM. There's a small fix with a regression test ready in https://github.com/InsertKoinIO/koin-compiler-plugin/pull/111. Could it be merged and released as a patch? Thanks! 🙏
👍 1
a
ok, adding it to the fix queue @Matouš Skála
🙌 1