Which is preferable between - `ClassId.topLevel(F...

# compiler

[min]

Which is preferable between
• ClassId.topLevel(FqName("kotlin.jvm.JvmSynthetic"))
• ClassId.topLevel(FqName(JvmSynthetic::class.qualifiedName!!))

[Youssef Shoaib [MOD]]

It's a matter of taste really. I'd probably go with the latter

[jw]

In general I prefer the former, since the latter only does what you expect if the type is not a typealias

[min]

@jw Sorry, what do you mean?

the latter only does what you expect

And the former does more than what you expect?

[Youssef Shoaib [MOD]]

The latter (::class.qualifiedName) doesn't work well for type aliases (it'll give you the underlying class's fqn)

[min]

Ah, I think I understand. Foo::class.qualifiedName where import com.example.MyClass; typealias Foo = MyClass returns com.example.MyClass not $package.Foo? Does that cause any problems when passed to FqName then ClassId.topLevel?

[Youssef Shoaib [MOD]]

It depends on the situation. If you want to detect the type alias itself or if e.g. it's an actual typealias then you might face issues.

[min]

Got it, thanks!

[jw]

Try it with List and MutableList