Hey folks, this is fairly small and succint but wa...

# announcements

[Gabriel]

Hey folks, this is fairly small and succint but was wondering if there was a "nicer"/more kotlinesque way of doing it?

val avatarList = mutableListOf<Int>(1,2,3)

fun generateRandomAvatar(): Int? {
	val pick = avatarList.randomOrNull()
	if (pick !== null) avatarList.remove(pick)
	return pick
}

[appasni]

I would make the generateRandomAvatar receive a MutableList.

[appasni]

Unless the whole code you posted is in a dedicated class.

[Gabriel]

@appasni yeh it's in it's own file

[Alexis Manin]

A quick one to avoid two accesses in list :

kotlin
fun <T> MutableList<T>.removeRandomOrNull() : T? {
    return if (isEmpty()) null;
    else removeAt(random().nextInt(0, size))
}

[Gabriel]

Ah that's a good idea, add an extension, thanks @Alexis Manin

[Gabriel]

And this we can change the function to just

fun generateRandomAvatar() = avatarList.removeRandomOrNull()

[Youssef Shoaib [MOD]]

You can also change the original to be a one-liner:

val avatarList = mutableListOf<Int>(1,2,3)
fun generateRandomAvatar(): Int? = avatarList.randomOrNull()?.also { avatarList.remove(it) }

[nkiesel]

instead of random().nextInt(0, size) you could also use indices.random(). However, I like the .also approach best