Is there a neater way to do this?

# announcements

[Tim Malseed]

Is there a neater way to do this?

[Tim Malseed]

override fun onResponse(call: Call, response: Response) {
    if (response.isSuccessful) {
        response.body?.let { body ->
            continuation.resume(body.byteStream())
        } ?: continuation.resumeWithException(IOException("Request failed: $response"))
    } else {
        continuation.resumeWithException(IOException("Request failed: $response"))
    }
}

[Tim Malseed]

My first thought was:

override fun onResponse(call: Call, response: Response) {
    if (response.isSuccessful) {
        response.body?.let { body ->
            continuation.resume(body.byteStream())
            return@let
        }
    }

    continuation.resumeWithException(IOException("Request failed: $response"))
}

But the 'early return' doesn't actually exit the outer scope

[Tim Malseed]

Oh, I'm a dumbass.

[Tim Malseed]

Just need to return instead of return@let. Confused myself trying to solve a problem I didn't have

[Youssef Shoaib [MOD]]

You can also do if(response.isSuccessful && response.body != null) { //resume with stream } else //resume with exception

[Youssef Shoaib [MOD]]

Alternatively, you could also make a body property that returns null if the response wasn't successful i.e. like this:

val Response.successfulBody get() = if(response.isSuccesful) response.body else null

and then:

override fun onResponse(call: Call, response: Response) {
    response.successfulBody?.let { body ->
        continuation.resume(body.byteStream())
    } ?: continuation.resumeWithException(IOException("Request failed: $response"))
}

or even turn it into a one-liner if you want:

override fun onResponse(call: Call, response: Response) = response.successfulBody?.let { continuation.resume(it.byteStream()) } ?: continuation.resumeWithException(IOException("Request failed: $response"))