Anybody have thoughts on the performance of the fo...

# announcements

[Nathan Retta]

Anybody have thoughts on the performance of the following code block? I came across this in our project and I feel like this would not perform well

inline fun <reified T> HashMap<String, T>.toAnalyticsBundle(): Bundle {
    val analyticsRegex = Regex(FirebaseAnalyticsManager.ANALYTICS_REGEX_STRING)

    return Bundle().apply {
        for (key in keys) {
            val value = this@toAnalyticsBundle[key]
            val firebaseKey = FirebaseAnalyticsManager.googleAnalyticsifyString(key, analyticsRegex)
            when (value) {
                is Int -> [e-mail](firebaseKey, value)
                is Float -> [e-mail](firebaseKey, value)
                is Double -> [e-mail](firebaseKey, value)
                is Boolean -> [e-mail](firebaseKey, value)
                is Char -> [e-mail](firebaseKey, value)
                is String -> [e-mail](firebaseKey, value)
                is Parcelable -> [e-mail](firebaseKey, value)
                is Serializable -> [e-mail](firebaseKey, value)
            }

        }
    }
}
fun googleAnalyticsifyString(stringToConvert: String, regex: Regex = Regex(ANALYTICS_REGEX_STRING)): String {
    val charArray = stringToConvert.toLowerCase().replace(regex, "").toCharArray()
    for((index, char) in charArray.withIndex()) {
        if(char == ' ') {
            val nextCharIndex = index + 1
            if(nextCharIndex < stringToConvert.length) {
                charArray[nextCharIndex] = charArray[nextCharIndex].toUpperCase()
            }
        }
    }
    return charArray
        .joinToString("")
        .replace(" ", "")
}

[georg]

I would suggest to write a test, feed it lots of input and measure the performance. No need to optimize code if there’s no problem.