Is there a more Kotlin-like alternative to express...

# announcements

[Edoardo Luppi]

Is there a more Kotlin-like alternative to express this piece of code?

var n = completionProviders.indexOfFirst(...) + 1

if (n == 0) {
  n = completionProviders.size
}

Not with takeUnless/takeIf

[Rob Elliot]

Not sure it’s any better, but I’d be tempted by this:

inline fun <T> List<T>.indexOfFirstOrNull(predicate: (T) -> Boolean): Int? {
    val indexOfFirst = indexOfFirst(predicate)
    return if (indexOfFirst >= 0) indexOfFirst else null
}

completionProviders
    .indexOfFirstOrNull { it == ... }
    ?.let { it + 1 }
    ?: completionProviders.size

[Nir]

Why no takeIf? Seems like the natural continuation

[Nir]

Would be good to know the reason otherwise other offered solutions might have the same issue

[Nir]

val n = completionProviders.indexOfFirst(...).let { if (it == -1) completionProviders.size else it + 1 }

[Nir]

I like Rob's solution as well, never really understood or liked the -1 convention in a language with built in null handling

[ephemient]

boxed integer :(

[Edoardo Luppi]

@Nir I don't like those two functions with primitive data types, that's all 😆

[Nir]

Some kind of performance thing I guess?

[Edoardo Luppi]

@Rob Elliot thanks! But doesn't it seem like overcomplicating the thing?

[Edoardo Luppi]

@Nir no, just one of my rules/preferences

[Edoardo Luppi]

@Nir but yeah. It doesn't make sense to allow wrapper classes here, as it would happen with takeIf

[ephemient]

maybe inline classes someday

Untitled

[Nir]

@Edoardo Luppi I have to admit then I just don't understand outside of performance reasons what the motivation is

[Nir]

Perf wise hard for me to comment, it's not an ultra high perf language, so worrying about microoptimizations seems suboptimal

[Edoardo Luppi]

@Nir a clear distinction of applicability for extension functions

[Edoardo Luppi]

In the end I pushed as it was
https://github.com/lppedd/idea-conventional-commit/commit/61639260425127ea4f33fe404cdef43de1260067#diff-2d1d956016b802495f34f4d8a200b9368485c38fd6afb03067dc38a0e298ff7cR200