Nick
11/10/2020, 2:39 PMview.findViewById<AppCompatTextView>(
R.id.strike_price
)?.let {
it.text = price.toString()
}
Would you nit
this, or request changes?
1️⃣ nit
2️⃣ request changes, unnecessary use of let
spand
11/10/2020, 2:43 PMmethod {
singleLine
}.somethingElse {
againSingleLine
}
I much prefer:
view
.findViewById<AppCompatTextView>(R.id.strike_price)
?.text = price.toString()
Nick
11/10/2020, 2:46 PMnit
it or request changesNir
11/10/2020, 3:19 PMit?.text = ...
louiscad
11/10/2020, 3:24 PMIrving Rivas
11/10/2020, 3:51 PMlet
block later. Since it’s very cut and dry — it’s literally an unnecessary code block — it’s best not to allow the codebase to get littered by these.Irving Rivas
11/10/2020, 3:53 PM