(slightly prematurely) looking at 1.4, and seeing a new compiler warning I don't quite understand. ...

# announcements

[Joe]

(slightly prematurely) looking at 1.4, and seeing a new compiler warning I don't quite understand. In the following class: https://github.com/trib3/leakycauldron/blob/master/testing/src/test/kotlin/com/trib3/testing/db/DAOTestBaseTest.kt
lines 30 and 48 both look like:

var reached = false

With 1.4, line 30 triggers the following warning, but line 48 does not:

DAOTestBaseTest.kt: (30, 23) Variable 'reached' initializer is redundant

I can fix by replacing with var reached: Boolean, but would like to understand why the 2 instances are being treated differently first.

[Nir]

Aren't asserts run conditionally?

[Nir]

I guess it depends what flavor of assert this is

[Nir]

Anyhow, I don't know if the compiler is wrong to think that, but clearly the difference is that the subsequent write is wrapped in an assertThat

[Joe]

asserts from from assertk, tests run via testng, fwiw

[Nir]

The compiler feels confident that the code inside use will simply always run

[Nir]

So it calls out line 30 as a dead write

[Nir]

To say that line 48 is a dead write, you need to not that both use and assertThat unconditionally call the passed lambda

[Nir]

*know that

[Nir]

so I would conclude from this that the compiler for whatever reason isn't comfortable assuming that assertThat always executes its lambda.

[Joe]

ah, dead write makes sense as an explanation to me, clearer than redundant initializer at least, thanks!

[Nir]

np