when are generics going to be fixed?

# announcements

[Ryan]

when are generics going to be fixed?

[Zach Klippenstein (he/him) [MOD]]

In what particular ways do you consider them broken?

[Ryan]

val col = co.preshow.db.PreshowVideoWatchLogs.watchTimeInMilliseconds.max()
    val videoToWatchTime = user?.let {
        co.preshow.db.PreshowVideoWatchLogs.slice(col, co.preshow.db.PreshowVideoWatchLogs.video)
                .select { co.preshow.db.PreshowVideoWatchLogs.user.eq(user.id).and(co.preshow.db.PreshowVideoWatchLogs.video.inList(videos.map { it.video.id })) }
                .groupBy(co.preshow.db.PreshowVideoWatchLogs.video)
                .map {
                    it[co.preshow.db.PreshowVideoWatchLogs.video].value to it[col]
                }.toMap()
    } ?: kotlin.collections.emptyMap()

[Ryan]

i have to pull out PreshowVideoWatchLogs.watchTimeInMilliseconds.max()

[Ryan]

into its own variable to reference it

[Ryan]

Screen Shot 2020-06-15 at 8.39.01 AM.png,Screen Shot 2020-06-15 at 8.38.44 AM.png,Screen Shot 2020-06-15 at 8.40.58 AM.png

[Joost Klitsie]

What about return type Single<out User>

[Ryan]

breaks stuff further down the line

[Joost Klitsie]

And what if you add null safety?

[Joost Klitsie]

does it behave differently then?

[Joost Klitsie]

hmm.... sounds a bit stupid when I type it out 🙂

[Ryan]

I think the compiler is getting too quirky

[Ryan]

much like how every variable is public unless noted, same should be for generics.

[Ryan]

no restrictions

[Joost Klitsie]

perhaps with the new type inference of Kotlin 1.4 it will be better

[Ryan]

perhaps

[Kroppeb]

the ide should be using new inference already

[Kroppeb]

Have you tested if it compiles? Might be a new bug?
And what is Single<T>?

[Zach Klippenstein (he/him) [MOD]]

You can opt-in to the new inference even if you're not on 1.4, I'd be curious if that changes anything

[Kroppeb]

the ide should be using new inference already

[Ryan]

Single is from rx, T is just a generic.