Is there a more succinct way of doing this in Kotl...

# announcements

[mjthornton]

Is there a more succinct way of doing this in Kotlin?

Untitled

[Shawn]

where are you getting minDistance from?

[mjthornton]

Stored earlier within the same function

[mjthornton]

Untitled.kt

Untitled.kt

[mjthornton]

I tried ☝️ but I need to perform two operations, so the ?: was not working for me

[mjthornton]

i.e

Untitled

[Shawn]

it seems like maybe you should consolidate assignment of minDistance

[mjthornton]

Untitled

Untitled

[mjthornton]

I need minDistance available to two different functions

[Shawn]

two different functions? is it supposed to be a class member instead?

[mjthornton]

It’s declared in a parent function

Two functions within the parent scope use minDistance

[Shawn]

a parent function? isn’t this function a private class member?

[Shawn]

I’m having trouble following the intent of the function (there’s a lot of context and it’d be hard to convey over the internet), but I’d recommend not overly relying on .let if you can

[mjthornton]

Okay, I might go back to using
if( != null )

[Shawn]

you can also avoid unnecessary nesting of scopes by returning early in the function and maybe continue - ing early in the loop

[mjthornton]

It’s more legible

[Shawn]

unsure how the types shake out here but you might just be able do this early on?

val dataSet = lineData.getDataSetByLabel("BG", true) ?: return

[Bob Glamm]

Boolean truth tables to the rescue:

if (minDistance == null || (minDistance != null && calcDistFromBolus < minDistance)) {
  minDistance = calcDistFromBolus
  closestEntry = bolusStartEndEntries[0].data as BolusDisplayModel
}

[mjthornton]

Thanks @Bob Glamm … I got so wrapped up in trying to use scoping functions

[mjthornton]

Sometimes the basics are better

[mjthornton]

Thanks again @Shawn

[Jiri Bruchanov]

wouldn't be better to use something like

Int.MIN_VALUE

instead of null ?

[Shawn]

not in the case where any integer value is potentially valid

[Shawn]

it would also make calcDistFromBolus < minDistance always false

[Shawn]

(well, min_value anyhow, you could use max instead maybe)

[Jiri Bruchanov]

yeah I mean for your context of usage of course...
I think it's better to avoid null values in cases like that...

and if you say "any integer" is potentially valid for min/max, you are already kinda in trouble with overflow

[mjthornton]

@Jiri Bruchanov That worked… but I’m using Int.MAX_VALUE

[mjthornton]

Didn’t know that existed

[Jiri Bruchanov]

👍

[mjthornton]

Originally I was using:
minDistance = 999999

But I felt like that looked dirty

[Roger Home-Martinsen]

Untitled

Untitled

[Roger Home-Martinsen]

⬆️ More or less the same as @Bob Glamm, but I think that we don’t need the null check