A modern programming language that makes developers happier.

kotlinlang

Untitled

Is there a more succinct way of doing this in Kotlin?

where are you getting `minDistance` from?

Untitled.kt

I tried :point_up: but I need to perform two operations, so the ?: was not working for me

it seems like maybe you should consolidate assignment of `minDistance`

I need minDistance available to two different functions

two different functions? is it supposed to be a class member instead?

It’s declared in a parent function

Two functions within the parent scope use minDistance

a parent function? isn’t this function a private class member?

I’m having trouble following the intent of the function (there’s a lot of context and it’d be hard to convey over the internet), but I’d recommend not overly relying on `.let` if you can

Okay, I might go back to using
if( != null )

you can also avoid unnecessary nesting of scopes by returning early in the function and _maybe_ `continue` - ing early in the loop

unsure how the types shake out here but you might just be able do this early on?

```val dataSet = lineData.getDataSetByLabel("BG", true) ?: return```

Boolean truth tables to the rescue:
```
if (minDistance == null || (minDistance != null &amp;&amp; calcDistFromBolus &lt; minDistance)) {
  minDistance = calcDistFromBolus
  closestEntry = bolusStartEndEntries[0].data as BolusDisplayModel
}```

Thanks <@UE3D4UE15> … I got so wrapped up in trying to use scoping functions

wouldn't be better to use something like
```Int.MIN_VALUE```
instead of null ?

not in the case where any integer value is potentially valid

it would also make `calcDistFromBolus &lt; minDistance` always false

(well, `min_value` anyhow, you could use max instead _maybe_)

yeah I mean for your context of usage of course...
I think it's better to avoid null values in cases like that...

and if you say "any integer" is potentially valid for min/max, you are already kinda in trouble with overflow

<@UQXHFKSAU> That worked… but I’m using Int.MAX_VALUE

Originally I was using:
minDistance = 999999

But I felt like that looked dirty

:arrow_up:  More or less the same as <@UE3D4UE15>, but I think that we don’t need the null check