For `typealias` naming - which style do you prefer...

# announcements

[zak.taccardi]

For typealias naming - which style do you prefer?

() -> Int

// 1
typealias ProvideNumber = () -> Int

// 2
typealias NumberProvider = () -> Int

Usage then becomes either provideNumber() or `numberProvider()`/`numberProvider.invoke()`

[zak.taccardi]

I’ve personally leaned towards ProvideNumber because it’s a function that provides a number - functions are verbs

[zak.taccardi]

provideNumber() also reads better

[diesieben07]

From the two option I'd say NumberProvider. However I'd argue that that is not a useful typealias. () -> Int is already Kotlin-Speak for NumberProvider.

[zak.taccardi]

it’s an example

[diesieben07]

Better to use a meaningful type (instead of just Int) and the use () -> UserAge (as an example)

[zak.taccardi]

correct, but that is a different topic

[zak.taccardi]

you would still use a typealias for the provider because () -> UserAge could become suspend () -> UserAge and you would have to pass around that info

[diesieben07]

You'd still have to touch (possibly) all call-sites because you'd have to now account for the suspension.

[zak.taccardi]

sure, but that’s not relevant

[diesieben07]

I just don't know what advantage the name XProvider has over () -> X

[Dominaezzz]

NumberProvider as a type name but provideNumber as a variable/function name.

[zak.taccardi]

@diesieben07

val provideOne: () -> Int = { 1 }
val provideTwo: () -> Int = { 2 }

now lets say I change () -> Int to be suspend () -> Int. I have to update the type for both provideOne and provideTwo . Whereas if I used a typealias instead of () -> Int, I wouldn’t have to update the definition.

Wherever you specify () -> Int again for what is the same type (NumberProvider) you are duplicating code (repeating yourself)

() -> Int is effectively specifying 3 pieces of information: non-suspending function that takes no parameters that returns an Int. Which means when you have to update any of those 3 pieces, everywhere you specify () -> Int needs to be updated, instead of just updating the typealias and fixing any potential compile errors

[zak.taccardi]

NumberProvider as a type name but provideNumber as a variable/function name.

I’ve actually done that, but construction seems a little weird. but definitely a third option

SomeClass(provideNumber = numberProvider)