Hi guys, I'm facing a dilemma and I need your advi...

# announcements

[wathek]

Hi guys, I'm facing a dilemma and I need your advice. Which one of these two lines you think is better:
val parsedValue = if (propertyValue is String) propertyValue.toDouble() else propertyValue as Double
VS
val parsedValue = (propertyValue as? String)?.toDouble() ?: propertyValue as Double

[Shawn]

first

[Shawn]

but what type is propertyValue even

[wathek]

@Shawn any reason why you think it's better ?

[Shawn]

looking at the statements in a vacuum I like the first better because it’s much clearer what’s happening

[wathek]

@Shawn propertyValue is Any

[Shawn]

are you okay with that potential ClassCastException lying in wait lol

[wathek]

yes I'm ok with that potential ClassCastException that can come from as Double

[Mike]

Agree with Shawn.

The second one takes a lot of 'processing' to figure out what is going on. The first is obvious.