huh == Boolean.TRUE made it go away

# announcements

[adam-mcneilly]

huh == Boolean.TRUE made it go away

[Shawn]

another oddity to file away for later 🤔

[adam-mcneilly]

lmao yep

[adam-mcneilly]

Wouldn't it still need to unbox to perform this comparison? 🤔

[Shawn]

You know, I’ve been wrangling with that in my head

[Shawn]

Wait, no, not in Java since == is identity

[Shawn]

Hm, wait, no, that probably isn’t explaining it properly either lmao

[adam-mcneilly]

lmao

[Shawn]

I might fire up the bytecode viewer and see what’s different about primitive comparisons

[adam-mcneilly]

I am going to hardcode this property as null and see if it crashes

[adam-mcneilly]

It could be a primitive thing though. This could work in the same way that getCount() == 2 works, for example.

[adam-mcneilly]

👨‍🔬 I come back to report that config.isTransparentToolbar() == Boolean.TRUE will not crash if it's null. Thanks for all the help.

[karelpeeters]

I would not do that, ever. java.lang.Boolean isn't a proper "dualton", you can create new instances: https://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#Boolean(boolean)

[karelpeeters]

Boolean(true) != Boolean.TRUE ☕

[Shawn]

aw beans

[Shawn]

why is that constructor even public

[karelpeeters]

I don't understand why they did that either 🤔

[karelpeeters]

Probably from a time when effective Java hadn't come out yet and factory methods weren't popular yet. simple smile

[adam-mcneilly]

Oh wow. So then what's an alternative to handling this unboxing warning?

[Shawn]

Probably something like Boolean.TRUE.equals(config.isTransparentToolbar()) if I had to guess

[Shawn]

it looks terribly unintuitive, though, like I’d be pretty bewildered if I came across that line had Karel not explained the awfulness of Boolean to us

[louiscad]

FYI, Boolean boxes are cached… because there's only two values to cache. For other primitives (numbers), all values that cover Byte (-128 to 127) are cached, at least on Android.

[karelpeeters]

Boolean.valueOf(x) is cached, Boolean(x) can't be.

[karelpeeters]

Bigger question is why is your boolean nullable? Shouldn't that be an enum or something?

[adam-mcneilly]

It's a model object that I get from the server. I make all fields in my data class nullable so it can handle the server not supplying them or possibly sending null.

[karelpeeters]

Okay, makes sense simple smile

[adam-mcneilly]

Thank you for your help!