val bis = from.buffered()

        var b : ByteArray = byteArrayOf()
        while ( ( bis.read(b) ) != -1 ) {

        }

is there a better way to read in bytes in kotlin (yes the file is binary)

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io/java.io.-file/read-bytes.html ?

can't use that, this can apparently be up to 256G

you can't even do it that way really, you will need the result of

read

@Alan Evans yeah...

var bytes = ByteArray(72)
        var read = 0
        while ( ( read = bis.read(bytes) ) != -1 ) {
            for (byte in bytes) {
                addByte( byte )
            }
        }

kotlin doesn't like the assignment there

yeah 😞

is this some weird edge case where I'm going to have to write some of it in java

no no, but it won't look as clean that's all

yeah... this is a slurp though right, puts everything in the array, which I'm thinking I don't actually want... hmmm.... I think this is enough for me to work with though. Thanks

But you can hide it away:

fun InputStream.readInBlocks(blockSize: Int = 4096, function: (ByteArray, Int) -> Unit) {
    val buffer = ByteArray(blockSize)
    do {
        val count = read(buffer, 0, blockSize)
        if (count == -1) break
        function(buffer, count)
    } while (true)
}

Usage:

bis.readInBlocks { buffer, count ->
            // you got "count" bytes in buffer
        }

reads the stream until the stream is empty

ok, and oh and you might actually want to use

inline fun

as that would save a lot of function calls over 256GB of small blocks.

my confusion is it's before 10am and java's io api... 😉 but yes... more caffeine

Not particularly. I would just say apply same reasoning as any other function: Do you need to access it from multiple classes? then put somewhere they can all access it. If just for one place, you can put at the bottom of that file and keep

private fun

. Remember you can always move later, and I think it's best to keep visibility of anything, class, function or property, to the minimum you need.

Okio

?