Any idea how to write this piece of code nicer? ``...

# announcements

[jcechace]

Any idea how to write this piece of code nicer?

override fun checkServerTrusted(chain: Array<out X509Certificate>?, authType: String?) {
        try {
            customTm?.checkServerTrusted(chain, authType) ?: defaultTm.checkServerTrusted(chain, authType)
        } catch (e : CertificateException) {
            defaultTm.checkServerTrusted(chain, authType)
        }
    }

[maxmello]

You could throw an Exception on the right side of the elvis operator

[jcechace]

Yea…probably would be more readable but it has this “Using exception to control execution flow” anti-pattern feeling to it

[maxmello]

Only alternative I can think of:

override fun checkServerTrusted(chain: Array<out X509Certificate>?, authType: String?) {
        fun checkCustomTm() = return try {
				customTm?.checkServerTrusted(chain, authType)
			} catch (e : CertificateException) {
				null
			}
		}
		checkCustomTm() ?: defaultTm.checkServerTrusted(chain, authType)
    }

[camkadev]

my 5 cents
override fun checkServerTrusted(chain: Array<out X509Certificate>?, authType: String?) {
try {
when(val tm = customTm){
null -> defaultTm.checkServerTrusted(chain, authType)
else ->
tm.checkServerTrusted(chain, authType)
}
} catch (e : CertificateException) {
defaultTm.checkServerTrusted(chain, authType)
}
}