Marcus Fihlon
07/23/2018, 3:05 PMShawn
07/23/2018, 3:24 PM@irus
@madhead
, and @y2k_
. Based on recent commit history, I’d get in contact with IRus if I really had to. All three have accounts on this workspace, but I don’t know if I’d personally be comfortable reaching out, considering they’re probably aware of the PR already.Shawn
07/23/2018, 3:27 PMclosing
in your commit messages might not trigger GitHub’s automatic issue closing feature. You might need to rebase and rewrite them to say closes
or resolves
instead, see https://help.github.com/articles/closing-issues-using-keywords/Shawn
07/23/2018, 3:30 PMtapchicoma
07/24/2018, 6:32 AM