Hello, currently I'm working with a legacy method ...

# announcements

[Edwin Miguel]

Hello, currently I'm working with a legacy method that throws an exception when error occurs. I could wrap it with a new one and rethrow to an upper layer, but also, I could create a sealed class to represent the response of the method (success or error). What do you think is the best approach. I would prefer to used sealed classes (or maybe a functional Either) than rethrowing errors.

[nfrankel]

I would prefer to used sealed classes (or maybe a functional Either) than rethrowing errors.

why?

What do you think is the best approach.

1. it depends. there’s no context to base any advice on
2. you already stated what you prefer. go for it

[Edwin Miguel]

I would like to have a good reason why not to spread the code with try/catch blocks, maybe security concerns, etc

[nfrankel]

for me, it’s perfectly fine to throw a subclass of runtime exception
and catch it where it makes sense
so only one try/catch block
if you are a functional programmer
this probably sends shivers up your spine

[Edwin Miguel]

Hehe, thanks a lot for your point of view 👍 I'm gonna take it into account

[nfrankel]

but again
it depends on your context
if you’re an oop/java programmer
this is your bread and butter
if you’re a fp/haskell programmer
this is weird