I'd like some feedbacks, because I have the feelin...

# announcements

[elect]

I'd like some feedbacks, because I have the feeling I'm gonna get bitten by this issue sooner or later.
I have generic interfaces Vec3t<Number> implemented as Float, Int, etc..
Of course methods differing only for a different type (i.e: dot(v: Vec3t<Number>) and dot(v: Vec3t<Float>)) have the same signature, but if I try to call:

val vert = Vec3() // Vert3 : Vec3t<Float>
vert.dot(fromTo) // error, none of the following functions can be called. Note that dot is dot(v: Vec3t<Number>)

I have to either change dot to dot(v: Vec3t<Float>) or create a new set of interfaces, where I have Vec3tNumber and Vec3tFloat and so on..
What do you think?

[Andreas Sinz]

can you show us the code of your interface Vec3t ?

[elect]

https://github.com/kotlin-graphics/glm/blob/master/src/main/kotlin/glm_/vec3/Vec3t.kt

[Andreas Sinz]

you've defined the generic type T but you are actually using Number everywhere. Is there a specific reason for that?

[elect]

I need a generic type that shall be extended by the given implementation

[elect]

what do you suggest?

[Andreas Sinz]

i have the gut feeling that the whole Vec3 code can be simplified a lot if we make proper use of generics

[Andreas Sinz]

should the API stay the same?

[elect]

I like your gut feeling

[elect]

what do you suggest

[Andreas Sinz]

alright, lets start with the smaller ones: in every subclass you have operators like plus, minus etc

[Andreas Sinz]

those functions just need a way to create a new instance of the subclass, then you can move many of the implementations into the base-class

abstract class Vec3t<T: Number>(...) {
    abstract protected inline fun createInstance(): Vec3t<T>

    operator fun plus(t: T) = plus(createInstance(), this, t, t, t)
    operator fun plus(t: Vec3t<T>) = plus(createInstance(), this, t.x, t.y, t.z)
}

[Andreas Sinz]

all you have to do now is implement createInstance inside your Vec3i and you get plus operator for free

[Andreas Sinz]

same for minus, times, div

[elect]

clever hints

[elect]

thanks dear

[elect]

"inline" modifier is not allowed on virtual members

[Andreas Sinz]

eh, remove that inline from createInstance, its not needed