I’m baffled. And the bytecode viewer is not helpin...

# announcements

[cedric]

I’m baffled. And the bytecode viewer is not helping because it throws an exception 🙂

[gildor]

My bytecode viewer shows that only constructor param annotated

[cedric]

but it’s a val, shouldn’t it be present somewhere in the class as well, either as a field or property?

[gildor]

@field:Json annotates field explicitly

[cedric]

Yes I know that works, I just don’t want to import this on users, it should be possible to do without

[gildor]

Not sure about annotation application strategy by default

[gildor]

What about AnnotationTarget.PROPERTY?

[cedric]

The target is a compile time check only, my code wouldn’t compile otherwise

[cedric]

the target is already on PROPERTY

[gildor]

Oh, yeah

[gildor]

do you use Kotlin-reflect?

[cedric]

yup

[gildor]

I suppose you can get property annotation using kotlin-reflect

[cedric]

The code I pasted above wouldn’t compile without it 🙂

[gildor]

Okay, got it

[elizarov]

The target is not check only. It drives where it is applied via some rules.

[elizarov]

@udalov

[cedric]

I mean a runtime look up cannot fail because the target is wrong since your code wouldn’t even have compiled if the target was wrong

[cedric]

or maybe that problem I’m currently running into is showing I don’t understand how this works 🙂

[gildor]

@cedric Works for me with memberProperties instead of declaredMemberProperties

[cedric]

Interestingly, I also observed that

[cedric]

I was fixing a bug by doing this replacement and all kinds of regressions appeared

[gildor]

Hmm, nope doesn’t work.
Probably worked for me only with explicit @property:Json

[gildor]

Works only if I have only AnnotationTarget.PROPERTY

[gildor]

Works if I remove AnnotationTarget.VALUE_PARAMETER

[cedric]

Wow you’re right, removing that target makes

val ann = it.findAnnotation<Json>()

work.

[cedric]

Sadly, this means I can no longer do

class Child(@Json(ignored = false) foo: String, val bar: String)

which I need

[gildor]

Still looks like a bug, or there is some not obvious reason for that

[cedric]

That’s my assessment too, hence why I summoned Roman 🙂

[gildor]

Maybe make sense to create an issue

[cedric]

Yes I will

[gildor]

Also, this is not an kotlin-reflect problem. because I don’t see synthetic accessor for property annotations in byte code of class if annotation contains AnnotationTarget.VALUE_PARAMETER

[cedric]

https://youtrack.jetbrains.com/issue/KT-23229

[cedric]

If you want to add comments

[gildor]

Yeah, added a comment