unless someone has a better idea

# announcements

[dh44t]

unless someone has a better idea

[ziggy42]

So you would

var total = getTotal()
val list = bankStatement.transactions.map {
    val currentTotal = total
    val totalBefore = currentTotal - it.amount
    total = totalBefore
    Something.fromThing(it, currentTotal, totalBefore)
}

[dh44t]

that should work

[dh44t]

Not sure why you need val currentTotal is still total

[dh44t]

ok, I see it

[ziggy42]

@menegatti suggested something better:

some.things.map { 
    Something.fromOtherThing(it, currentTotal, currentTotal - it.amount).also {
            currentTotal -= it.amount
    }
}

[dh44t]

yeah

[menegatti]

tbh, not sure it is better… I get a bit cautious around also because it might hinder readability

[menegatti]

it is smaller, but I’d definitely say the way the total amount is being used is funky

[ziggy42]

My version was very ugly imho. I like yours a lot more