``` println getMember $name when name toString gt return obj

Question

``` println getMember $name when name toString gt return obj toString valueOf gt return when obj is JsonNull gt null is JsonArray gt obj toString is JsonPrimitive gt if obj isNumber obj asNumber else if obj isBoolean obj asBoolean else obj asString else gt obj toString else gt try return obj name catch e NoSuchElementException return null ```

pawel.barszcz · Answer

deinspanjer Not an answer to your question but I would feel safer about types and `Any` too if I put one `return` before `when` instead of returning the whole function inside every branch of `when`

pawel.barszcz · Answer

I mean ``` return when gt someValue gt when gt is gt anotherValue else gt yetAnotherValue ``` so the whole `when` is an expression which evaulates to something and that something is then returned from function

deinspanjer · Answer

Hmm I m trying to implement a ScriptObjectMirror interface for Nashorn here and when it calls getMember it is expecting to get a function back so that is why I was trying to return lambdas

deinspanjer · Answer

I see what you mean though

pawel.barszcz · Answer

I think that it would be just more hmm idiomatic way of writing Kotlin

pawel.barszcz · Answer

and then the whole `when` would have some type propbably `Any` while now I guess it have `Nothing` type because you are calling `return` inside `when` and return is terminating the whole function so it s probably a type `Nothing`

deinspanjer · Answer

So maybe something like this ``` override fun getMember name String Any println getMember $name return when name toString gt obj toString valueOf gt when obj is JsonNull gt null is JsonArray gt obj toString is JsonPrimitive gt if obj isNumber obj asNumber else if obj isBoolean obj asBoolean else obj asString else gt obj toString else gt try obj name catch e NoSuchElementException null ```

pawel.barszcz · Answer

looks like

pawel.barszcz · Answer

wait I see you have remoed lambdas I will check in my IDE in a moment

pawel.barszcz · Answer

hmm are you sure that you want to return lambdas instead of values

pawel.barszcz · Answer

eg that ` obj toString ` returned in `toString` branch

pawel.barszcz · Answer

instead of just `obj toString ` as you have written in modified sample above

pawel.barszcz · Answer

Ah and BTW you are catching `NoSuchElementException` only when you still can have exception because of calling ` ` on nullable `name`

pawel.barszcz · Answer

so summing up my suggestion is as follows ``` return when name toString gt obj toString valueOf gt when obj is JsonNull gt null is JsonArray gt obj toString is JsonPrimitive gt if obj isNumber obj asNumber else if obj isBoolean obj asBoolean else obj asString else gt obj toString else gt try obj name catch e Throwable null ```