let’s hope you’ll never get to “-10”, because buil...

# announcements

[pniederw]

let’s hope you’ll never get to “-10”, because build tools would probably get that wrong (“-2" > “-10”)

[Ruckus]

pniederw: That's a good point

[ilya.gorbunov]

AFAIK build tools are capable of sorting numbers in versions as if they are numbers.

[Ruckus]

I was under the impression (though it may just be a semver thing) that sorting by number happened with the three numbers surrounding the `.`s, and everything after was treated as a string. I could be wrong though.
EDIT I was wrong, see below

[Ruckus]

I stand corrected

identifiers consisting of only digits are compared numerically and identifiers with letters or hyphens are compared lexically in ASCII sort order

[ilya.gorbunov]

What source are you quoting by the way?

[Ruckus]

That's from the semver spec http://semver.org/#spec-item-11
I'm not sure how that applies to the various build tools though.

[ilya.gorbunov]

Probably semver applies to none of the relevant ones (maven, gradle)

[pniederw]

@ilya.gorbunov I’m pretty sure maven and gradle compare anything after the hyphen lexicographically

[ilya.gorbunov]

https://maven.apache.org/ref/3.3.3/maven-artifact/apidocs/org/apache/maven/artifact/versioning/ComparableVersion.html

[pniederw]

ok, might just be ivy and gradle 🙂

[pniederw]

I wrote some of that code, but don’t remember for sure.

[ilya.gorbunov]

Is it that one? https://github.com/gradle/gradle/blob/master/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/ivyservice/ivyresolve/strategy/StaticVersionComparator.java

[Ruckus]

Looks like it. @pniederw Your name is all over the blame 🙂 https://github.com/gradle/gradle/blame/master/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/ivyservice/ivyresolve/strategy/StaticVersionComparator.java

[pniederw]

all I remember is that the goal was to remain compatible with ivy, even though we ripped out the ivy impl

[Ruckus]

It looks like it has pretty similar rules to Maven. Version parts are broken on {'.', '_', '-'. '+'} and boundaries between digits and non-digits, and there can be an arbitrary amount of them. https://github.com/gradle/gradle/blob/master/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/ivyservice/ivyresolve/strategy/VersionParser.java

[pniederw]

happy to be proven wrong. 🙂 I added a test to https://github.com/gradle/gradle/blob/master/subprojects/dependency-management/src/test/groovy/org/gradle/api/internal/artifacts/ivyservice/ivyresolve/strategy/DefaultVersionComparatorTest.groovy to confirm, and it indeed gets it right.