Why was this closed without being implemented <https youtrac kotlinlang #ktor

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

r

ribesg

05/25/2022, 10:32 AM

Why was this closed without being implemented? https://youtrack.jetbrains.com/issue/KTOR-316 I’m checking on this issue every few months so that we can get rid of our custom cors plugin, and I discover that the issue was just closed. I’m kinda angry.

e

e5l

05/25/2022, 10:32 AM

@Rustam Siniukov could you take a look?

r

ribesg

05/25/2022, 10:33 AM

I found the commit I think https://github.com/ktorio/ktor/commit/cd8cac9ada241ea9c04881b67e2bf34803e9a37b

Splitting on

is NOT how you handle regexes.

The issue title is “Pattern matching for origin”. The commit implements wildcard support. It’s something that was missing, but it is not what the issue was really about

Exposing a validation function would just let the user do it’s own validation, with a regex or a list of regexes or whatever

r

Rustam Siniukov

05/25/2022, 1:22 PM

Please feel free to reopen it and add your use case with desired API

r

ribesg

05/25/2022, 1:22 PM

I’m actually working on a PR right now

👍 1

Here it is https://github.com/ktorio/ktor/pull/3023 Notes: I wasn’t able to run

./gradlew assemble

, I have

curl

and

ncurses

installed already but I had an error about macos arm64 or something, I’m on a x64 Mac. But

./gradlew jvmTest

passed.

r

Rustam Siniukov

05/25/2022, 3:14 PM

Thanks. I’ll review it this week.

👍 1

3 Views

#ktor Join Slack