Why was this closed without being implemented? <ht...

# ktor

[ribesg]

Why was this closed without being implemented? https://youtrack.jetbrains.com/issue/KTOR-316
I’m checking on this issue every few months so that we can get rid of our custom cors plugin, and I discover that the issue was just closed. I’m kinda angry.

[e5l]

@Rustam Siniukov could you take a look?

[ribesg]

I found the commit I think https://github.com/ktorio/ktor/commit/cd8cac9ada241ea9c04881b67e2bf34803e9a37b

[ribesg]

Splitting on * is NOT how you handle regexes.

[ribesg]

The issue title is “Pattern matching for origin”. The commit implements wildcard support. It’s something that was missing, but it is not what the issue was really about

[ribesg]

Exposing a validation function would just let the user do it’s own validation, with a regex or a list of regexes or whatever

[Rustam Siniukov]

Please feel free to reopen it and add your use case with desired API

[ribesg]

I’m actually working on a PR right now

[ribesg]

Here it is https://github.com/ktorio/ktor/pull/3023

Notes: I wasn’t able to run ./gradlew assemble, I have curl and ncurses installed already but I had an error about macos arm64 or something, I’m on a x64 Mac. But ./gradlew jvmTest passed.

[Rustam Siniukov]

Thanks. I’ll review it this week.