https://kotlinlang.org logo
#ktor
Title
# ktor
r

ribesg

05/25/2022, 10:32 AM
Why was this closed without being implemented? https://youtrack.jetbrains.com/issue/KTOR-316 I’m checking on this issue every few months so that we can get rid of our custom cors plugin, and I discover that the issue was just closed. I’m kinda angry.
e

e5l

05/25/2022, 10:32 AM
@Rustam Siniukov could you take a look?
r

ribesg

05/25/2022, 10:33 AM
Splitting on
*
is NOT how you handle regexes.
The issue title is “Pattern matching for origin”. The commit implements wildcard support. It’s something that was missing, but it is not what the issue was really about
Exposing a validation function would just let the user do it’s own validation, with a regex or a list of regexes or whatever
r

Rustam Siniukov

05/25/2022, 1:22 PM
Please feel free to reopen it and add your use case with desired API
r

ribesg

05/25/2022, 1:22 PM
I’m actually working on a PR right now
👍 1
Here it is https://github.com/ktorio/ktor/pull/3023 Notes: I wasn’t able to run
./gradlew assemble
, I have
curl
and
ncurses
installed already but I had an error about macos arm64 or something, I’m on a x64 Mac. But
./gradlew jvmTest
passed.
r

Rustam Siniukov

05/25/2022, 3:14 PM
Thanks. I’ll review it this week.
👍 1
3 Views