Why was the single page plugin removed in <https:/...

# ktor

[ishitatsuyuki]

Why was the single page plugin removed in https://github.com/ktorio/ktor/pull/2824? Does that mean it's not ready for inclusion in EAP yet?

[ishitatsuyuki]

Nevermind, looks like I just need to add an extra dep.

[e5l]

@Daria Usova could you check?

[Daria Usova]

Sure, will check

[ishitatsuyuki]

fwiw, I added

implementation("io.ktor:ktor-server-single-page:2.0.0-eap-327")

and it's working fine. if the message above wasn't clear enough

[e5l]

Could you try -eap-300?

[ishitatsuyuki]

just wondering, what's different in that version?

[ishitatsuyuki]

actually, my wording was misleading. I was referring to this, which removed it from the core jar:
https://github.com/ktorio/ktor/pull/2824/commits/eab5d46a9790712344d9165b88a14db5140b0db4

[e5l]

It looks like a rebase issue

[ishitatsuyuki]

eap-300 doesn't have the plugin and it isn't a part of core either. so the build doesn't pass

[Daria Usova]

https://github.com/ktorio/ktor/pull/2824/commits/eab5d46a9790712344d9165b88a14db5140b0db4
Right, this code removed SPA from core because it was added by mistake. So you need to make

implementation("io.ktor:ktor-server-single-page:$ktor_version")