https://kotlinlang.org logo
Title
i

ishitatsuyuki

02/24/2022, 10:42 AM
Why was the single page plugin removed in https://github.com/ktorio/ktor/pull/2824? Does that mean it's not ready for inclusion in EAP yet?
Nevermind, looks like I just need to add an extra dep.
e

e5l

02/24/2022, 10:56 AM
@Daria Usova could you check?
d

Daria Usova

02/24/2022, 10:56 AM
Sure, will check
i

ishitatsuyuki

02/24/2022, 11:21 AM
fwiw, I added
implementation("io.ktor:ktor-server-single-page:2.0.0-eap-327")
and it's working fine. if the message above wasn't clear enough
e

e5l

02/24/2022, 11:21 AM
Could you try -eap-300?
i

ishitatsuyuki

02/24/2022, 11:22 AM
just wondering, what's different in that version?
actually, my wording was misleading. I was referring to this, which removed it from the core jar: https://github.com/ktorio/ktor/pull/2824/commits/eab5d46a9790712344d9165b88a14db5140b0db4
e

e5l

02/24/2022, 11:23 AM
It looks like a rebase issue
i

ishitatsuyuki

02/24/2022, 11:29 AM
eap-300 doesn't have the plugin and it isn't a part of core either. so the build doesn't pass
d

Daria Usova

02/24/2022, 12:25 PM
https://github.com/ktorio/ktor/pull/2824/commits/eab5d46a9790712344d9165b88a14db5140b0db4 Right, this code removed SPA from core because it was added by mistake. So you need to make
implementation("io.ktor:ktor-server-single-page:$ktor_version")