Just found this bug in beta-1 (also applies to `ap...

# ktor

[Chris C]

Just found this bug in beta-1 (also applies to appendIfNameAndValueAbsent())

public fun StringValuesBuilder.appendIfNameAbsent(name: String, value: String): StringValuesBuilder = apply {
    if (!contains(name)) return@apply
    append(name, value)
}

I think that if should be inverted

[Chris C]

not sure how that should be reported - there doesn’t seem to be a beta-1 version in youtrack (assuming that’s where it should be reported?)

[hfhbd]

Yes, youtrack is the right place. Just create two tickets, one for the bug and another for the version 😄

[Chris C]

done 👍

[Rustam Siniukov]

OMG, so embarrassing 🤦
thanks for noticing, will open PR shortly

[hfhbd]

Maybe with a test? 😄

[Rustam Siniukov]

There was a test that used this method, but I used headers.get(header) instead of headers.getAll(header) . Even more embarrassing 😃