question about testing in ktor-client:
So, runBlo...
# ktorp
Patrick Ramsey
09/01/2021, 6:25 AMquestion about testing in ktor-client:
So, runBlockingTest {} (from kotlin-test) creates a TestDispatcher and runs its block on said dispatcher, and then fails if any work is left running at the end of the test (say, on another dispatcher). I’d assume that the ktor MockEngine is meant to be used in tests as well (where best practice seems to be to use runBlockingTest {} instead of runBlocking {}).
But MockEngine creates its own dispatcher (by calling Dispatchers.clientDispatcher()), and calls to client.request() end up scheduling work on that dispatcher, which seems to cause tests that rely on a TestCoroutineDispatcher to fail.
Am I understanding this correctly, or am I missing something obvious?
a
Aleksei Tirman [JB]
09/01/2021, 9:01 AMPlease see the related conversation and KTOR-2629.
p
Patrick Ramsey
09/01/2021, 5:57 PMthanks!
Patrick Ramsey
09/01/2021, 5:57 PMsorry to rehash something already known!
Patrick Ramsey
09/01/2021, 6:07 PMoh interesting --- @Aleksei Tirman [JB] so I see now that the bug was declined. The sense I’ve gotten from blog posts and from #coroutines here is that using runBlocking {} in tests is considered bad practice --- is there any hope that being able to pass in a custom CoroutineDispatcher might happen? Or is it unlikely that it’ll be possible to test ktor code with a TestCoroutineDispatcher at any point in the future?
Patrick Ramsey
09/01/2021, 6:08 PM(this came up because I was going through and removing instances of runBlocking {} from our tests because it looked like we might have tests that were unwittingly leaking work onto other dispatchers)
a
Aleksei Tirman [JB]
09/01/2021, 6:08 PM@e5l please give a comment.
p
Patrick Ramsey
09/01/2021, 6:10 PMit’d be nice if MockEngine() at least allowed passing in a dispatcher/context!
Patrick Ramsey
09/01/2021, 6:11 PMthough I understand wanting to encapsulate that detail
e
e5l
09/01/2021, 6:12 PMHey @Patrick Ramsey , thanks for the notice. Ktor code needs actual suspension. We can provide such extension point, but I’m not sure that it will 100% solve the problem.
e5l
09/01/2021, 6:14 PMbtw let me investigate why runBlockingTest doesn’t work
p
Patrick Ramsey
09/01/2021, 6:14 PMfor my use case at least, I don’t need much of ktor’s internal logic to work --- I’m just using MockEngine because it’s not easy to mock the actual request() method (since that stuff’s all inline)
Patrick Ramsey
09/01/2021, 6:14 PMjust wanna test the code that uses it!
Patrick Ramsey
09/01/2021, 6:14 PMand thanks, @e5l for responding and for looking into it!
25 Views