Is anyone by chance aware of any threading related...

# ktor

[John O'Reilly]

Is anyone by chance aware of any threading related changes that were made in MockEngine in 1.5.1.....we're updating a client here from a 1.4.x version and have isolated issue we're seeing to update from 1.5.0 to 1.5.1.....we have unit tests that are using runBlockingTest and getting IllegalStateException: This job has not completed yet after that update....digging deeper to try and narrow in on what's changed but just in case anyone encountered this before....

[John O'Reilly]

Alternatively, are there any particular recommended best practices for setting up ktor related unit tests like this (that perhaps we weren't previously following)?

[Javier]

if you change runBlockingTest to runBlocking, it works?

[John O'Reilly]

So, that seems to affect things all right but other part of test fails then.....haven't had chance yet to dig in to that

[John O'Reilly]

I went through changelog for 1.5.1 but nothing jumped out

[John O'Reilly]

wondering if it might be related to following change (that was part of 1.5.1) https://github.com/ktorio/ktor/commit/a6d103f6c3f13c1a136a313112a47a6af7927137#diff-3d93b6d65cea408ebd78460acc5fea1e9fb27799795984595067d5e421f939d1

[Aleksei Tirman [JB]]

You can find an explanation here https://youtrack.jetbrains.com/issue/KTOR-2629

[John O'Reilly]

so, we can't use runBlockingTest for unit tests that use MockEngine ?

[Aleksei Tirman [JB]]

I did encounter the same issue and didn't find a way to solve it. @e5l is there a way to use runBlockingTest ?

[John O'Reilly]

perhaps pattern like following could be used to allow test to inject/replace dispatcher used? https://developer.android.com/kotlin/coroutines/coroutines-best-practices#inject-dispatchers

[e5l]

Hey @John O'Reilly. The problem is caused by context change in MockEngine. Most likely testing library you’re using is not assuming that there are no suspension points in test. It should be some await method there. Could you provide the whole code snippet to figure it out?

[John O'Reilly]

Hi @e5l, I'm not using any other testing library....just standard unit test with runBlockingTest and then testing one of our classes that in turn is using another class that uses MockEngine based HttpClient. Do you know of any examples/samples etc that are able to use runBlockingTest that I can maybe compare to?

[e5l]

Could you check if the code is working with a regular runBlocking?

[John O'Reilly]

Partly, yes....but running in to other issues then which I'm still trying to get to bottom of

[Aleksei Tirman [JB]]

The one problem is that you have to wait for all delays.

[John O'Reilly]

fwiw we're injecting TestCoroutineDispatcher() when constructing the class under test

[e5l]

Please note:

When switched to lazy execution using pauseDispatcher any coroutines started via launch or async will not execute until a call to DelayController.runCurrent or the virtual clock-time has been advanced via one of the methods on DelayController.

[e5l]

https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-test/kotlinx.coroutines.test/-test-coroutine-dispatcher/

[John O'Reilly]

we are using those in some other tests....let me see if/how they can be applied here too

[John O'Reilly]

Just to clarify though....we're not using pauseDispatcher in these particular tests right now