A modern programming language that makes developers happier.

kotlinlang

Hi! Is this the way to set content type in tests (I thought there would be a better way?):
```private fun ContentType.full() = "$contentType/$contentSubtype"

handleRequest(
        <http://HttpMethod.Post|HttpMethod.Post>, "/some-url") {
            addHeader(HttpHeaders.Accept, ContentType.Text.Plain.full())
        }```

They should really have some kind of `full()` function there, or even better, specialized header functions for testing that accept ContentType.

I guess more stuff in my utils package to add...

Why do you need `full` function? `ContentType`  has proper `toString`  function.
But we agree that testing API can be better and we are working on it. Please create sub tickets with your concerns or just write a comment here <https://youtrack.jetbrains.com/issue/KTOR-1649>

I looked for toString first... but AFAIK it doesn't give that... I think it gives what a regular data class would give, also, its not an obvious place to look for the valid complete content type string...

<@U01BRS7CT6D> the ticket is private.
But you are right, ContentType.Text.Plain.toString() results into "text/plain" and could be used with `addHeader(HttpHeaders.Accept, ContentType.Text.Plain.toString())`. Maybe it should accept `Any` like the client `header` api and call the `toString()` in `addHeader`

The `HeaderValueWithParameters` that ContentType inherits from has:
```    override fun toString(): String = when {
        parameters.isEmpty() -&gt; content
        else -&gt; {
            val size = content.length + parameters.sumBy { it.name.length + it.value.length + 3 }
            StringBuilder(size).apply {
                append(content)
                for (index in 0 until parameters.size) {
                    val (name, value) = parameters[index]
                    append("; ")
                    append(name)
                    append("=")
                    value.escapeIfNeededTo(this)
                }
            }.toString()
        }
    }```
And ContentType itself doesn't implement `toString()`... so how could that work <@U01JRLZH77T>?

`protected val content: String` in it does contain the full type, but it's protected...

<@U6P03BM0W> But its super class overrides `toString()`, so `ContentType.Text.Plain.toString())` results into `text/plain`.

Where do you see toString() here: <https://github.com/ktorio/ktor/blob/e425a2885f8e4ff0158c38c6595f2f2169fa3c9a/ktor-http/common/src/io/ktor/http/ContentTypes.kt>

And it's parent: <https://github.com/ktorio/ktor/blob/e425a2885f8e4ff0158c38c6595f2f2169fa3c9a/ktor-http/common/src/io/ktor/http/HeaderValueWithParameters.kt#L33>

You probably tried it out, and I just looked at the source code... I'm just a bit confused where that would come from...

Ok, I finally spotted it: `parameters.isEmpty() -&gt; content` :exploding_head:... I think this isn't so clear. It would be much better to add a property for this. But, you're right.

<@U01JRLZH77T> thanks, updated the visibility