in ktor 1 5 `expectSuccess` stopped working 1 4 3 triggered

Question

in ktor 1 5 `expectSuccess` stopped working 1 4 3 triggered `validateResponse` on 404 e t c now not ```fun HttpClientConfig lt gt myInit expectSuccess = false addMyValidator fun HttpClientConfig lt gt addMyValidator HttpResponseValidator validateResponse response gt ```

Rustam Siniukov · Answer

can you elaborate why you expect validation to be triggered if you set `expectSuccess` to `false` Validation should be executed only if you set `expectSuccess=true` and previous behaviour was wrong

Roman Vasilyev · Answer

< Rustam Siniukov> got it what is the right way to check responses

Rustam Siniukov · Answer

can you show your use case

Roman Vasilyev · Answer

```fun HttpClientConfig lt gt addMyValidator HttpResponseValidator validateResponse response gt val statusCode = response status value val originCall = response call if statusCode lt 300 return validateResponse val exceptionResponse = originCall response val exceptionResponseText = exceptionResponse readText when statusCode in 300 399 gt throw RedirectResponseException exceptionResponse exceptionResponseText 403 gt val bytes = exceptionResponse readBytes decodeToString val err = nonStrict decodeFromString ErrorResponse serializer bytes throw LoginRequiredException err exceptionResponse in 400 402 gt val bytes = exceptionResponse readBytes decodeToString val err = nonStrict decodeFromString ErrorResponse serializer bytes throw ErrorResponseException err exceptionResponse 404 gt throw ErrorResponseException ErrorResponse detail = Not found exceptionResponse in 405 499 gt throw ClientRequestException exceptionResponse exceptionResponseText in 500 599 gt throw ServerResponseException exceptionResponse exceptionResponseText else gt throw ResponseException exceptionResponse exceptionResponseText ```

Roman Vasilyev · Answer

< Rustam Siniukov> I need this logic triggered for every request

Roman Vasilyev · Answer

Rustam Siniukov · Answer

Ok so if I got it correct you need to add more exceptions to the default validation My suggestion would be to use default validation by setting `expectSuccess` to `true` but add more logic to `HttpResponseValidator` by adding `CallExceptionHandler` Something like this ```fun HttpClientConfig lt gt myInit expectSuccess = true addMyValidator fun HttpClientConfig lt gt addMyValidator HttpResponseValidator processException responseException gt if responseException is ClientRequestException return processException when responseException response status ``` This way you can extend the default behaviour without copy pasting framework code

Roman Vasilyev · Answer

< Rustam Siniukov> good approach will try it today

Roman Vasilyev · Answer

< Rustam Siniukov> after changes my validator looks like this and works with ` ktor 1 5 0` ```fun HttpClientConfig lt gt addMyValidator HttpResponseValidator handleResponseException responseException gt if responseException is ClientRequestException return handleResponseException val exceptionResponse = responseException response when exceptionResponse status HttpStatusCode Forbidden gt 403 val exceptionResponseText = exceptionResponse readText val err = nonStrict decodeFromString ErrorResponse serializer exceptionResponseText throw LoginRequiredException err exceptionResponse HttpStatusCode BadRequest HttpStatusCode Unauthorized gt in 400 401 val exceptionResponseText = exceptionResponse readText val err = nonStrict decodeFromString ErrorResponse serializer exceptionResponseText throw ErrorResponseException err exceptionResponse HttpStatusCode NotFound gt 404 throw ErrorResponseException ErrorResponse detail = Not found exceptionResponse ```

csieflyman · Answer

< Rustam Siniukov> I set expectSuccess = true and add validateResponse block to validate response body but ktor execute ktor default validateResponse block first and then throw exception Maybe use handleResponseException is a workaround solution for me

Roman Vasilyev · Answer

< csieflyman> according to Rustam `expectSuccess = true` should trigger `validateResponse` only for `statusCode lt 299`

csieflyman · Answer

< Roman Vasilyev> I got it I misunderstand ktor execute my validateResponse block first Ktor document gt This feature could be configured multiple times all validators and handlers are saved and called in order of install

Roman Vasilyev · Answer

< csieflyman> I just followed Rustams recommendation and happy slightly smiling face I don t is it expected behavior or not also it added more purity to my code as well