https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
r

Roman Vasilyev

01/06/2021, 5:52 AM
in ktor 1.5
expectSuccess
stopped working, 1.4.3 triggered
validateResponse
on 404 e.t.c, now not:
fun HttpClientConfig<*>.myInit() {
    expectSuccess = false
    addMyValidator()
}

fun HttpClientConfig<*>.addMyValidator() {
    HttpResponseValidator {
        validateResponse { response ->
        }
    }
}
r

Rustam Siniukov

01/06/2021, 12:23 PM
can you elaborate why you expect validation to be triggered if you set
expectSuccess
to
false
? Validation should be executed only if you set
expectSuccess=true
and previous behaviour was wrong
r

Roman Vasilyev

01/06/2021, 4:18 PM
@Rustam Siniukov got it, what is the right way to check responses?
r

Rustam Siniukov

01/06/2021, 4:20 PM
can you show your use case?
r

Roman Vasilyev

01/06/2021, 4:23 PM
fun HttpClientConfig<*>.addMyValidator() {
    HttpResponseValidator {
        validateResponse { response ->
            val statusCode = response.status.value
            val originCall = response.call
            if (statusCode < 300) return@validateResponse
            val exceptionResponse = originCall.response
            val exceptionResponseText = exceptionResponse.readText()
            when (statusCode) {
                in 300..399 -> throw RedirectResponseException(exceptionResponse, exceptionResponseText)
                403 -> {
                    val bytes = exceptionResponse.readBytes().decodeToString()
                    val err = nonStrict.decodeFromString(ErrorResponse.serializer(), bytes)
                    throw LoginRequiredException(err, exceptionResponse)
                }
                in 400..402 -> {
                    val bytes = exceptionResponse.readBytes().decodeToString()
                    val err = nonStrict.decodeFromString(ErrorResponse.serializer(), bytes)
                    throw ErrorResponseException(err, exceptionResponse)
                }
                404 -> {
                    throw ErrorResponseException(ErrorResponse(detail = "Not found"), exceptionResponse)
                }
                in 405..499 -> throw ClientRequestException(exceptionResponse, exceptionResponseText)
                in 500..599 -> throw ServerResponseException(exceptionResponse, exceptionResponseText)
                else -> throw ResponseException(exceptionResponse, exceptionResponseText)
            }
        }
    }
}
@Rustam Siniukov I need this logic triggered for every request
r

Rustam Siniukov

01/06/2021, 4:36 PM
Ok, so if I got it correct, you need to add more exceptions to the default validation. My suggestion would be to use default validation by setting
expectSuccess
to
true
, but add more logic to
HttpResponseValidator
by adding
CallExceptionHandler
. Something like this
fun HttpClientConfig<*>.myInit() {
    expectSuccess = true
    addMyValidator()
}
fun HttpClientConfig<*>.addMyValidator() {
    HttpResponseValidator {
        processException { responseException ->
          if (responseException !is ClientRequestException) return@processException
            when (responseException.response.status) {
              ...
            }
        }
    }
}
This way you can extend the default behaviour without copy-pasting framework code
r

Roman Vasilyev

01/06/2021, 4:51 PM
@Rustam Siniukov good approach, will try it today
@Rustam Siniukov after changes my validator looks like this and works with ` ktor 1.5.0`:
fun HttpClientConfig<*>.addMyValidator() {
    HttpResponseValidator {
        handleResponseException { responseException ->
            if (responseException !is ClientRequestException) return@handleResponseException
            val exceptionResponse = responseException.response
            when (exceptionResponse.status) {
                HttpStatusCode.Forbidden -> { // 403
                    val exceptionResponseText = exceptionResponse.readText()
                    val err = nonStrict.decodeFromString(ErrorResponse.serializer(), exceptionResponseText)
                    throw LoginRequiredException(err, exceptionResponse)
                }
                HttpStatusCode.BadRequest, HttpStatusCode.Unauthorized -> { // in 400, 401
                    val exceptionResponseText = exceptionResponse.readText()
                    val err = nonStrict.decodeFromString(ErrorResponse.serializer(), exceptionResponseText)
                    throw ErrorResponseException(err, exceptionResponse)
                }
                HttpStatusCode.NotFound -> { // 404
                    throw ErrorResponseException(ErrorResponse(detail = "Not found"), exceptionResponse)
                }
            }
        }
    }
}
c

csieflyman

01/08/2021, 1:40 AM
@Rustam Siniukov I set expectSuccess = true and add validateResponse block to validate response body, but ktor execute ktor default validateResponse block first and then throw exception. Maybe use handleResponseException is a workaround solution for me?
r

Roman Vasilyev

01/08/2021, 1:55 AM
@csieflyman according to Rustam
expectSuccess = true
should trigger
validateResponse
only for
statusCode < 299
c

csieflyman

01/08/2021, 2:13 AM
@Roman Vasilyev I got it. I misunderstand ktor execute my validateResponse block first. Ktor document -> This feature could be configured multiple times; all validators and handlers are saved and called in order of install.
r

Roman Vasilyev

01/08/2021, 2:15 AM
@csieflyman I just followed Rustams recommendation and happy 🙂 I don’t is it expected behavior or not, also it added more purity to my code as well