Anyone by chance also run in to following after up...

# ktor

[John O'Reilly]

Anyone by chance also run in to following after updating to Ktor 1.4.1? https://youtrack.jetbrains.com/issue/KTOR-1087

[russhwolf]

I don't hit that despite a very similar setup here https://github.com/russhwolf/multiplatform-hello/blob/master/shared-client/src/commonMain/kotlin/hello.kt

[russhwolf]

I wonder if sqldelight is causing you to pull in 1.3.9-native-mt instead of 1.3.9-native-mt-2

[John O'Reilly]

I'm using isForce = true on the kotlinx-coroutines dependency

[russhwolf]

Check ./gradlew dependencies anyway and see if there's anything surprising

[John O'Reilly]

yeah, it's using mt-2 e.g. for sqldelight

org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.3.9-native-mt-2

[John O'Reilly]

I updated KaMPKit to 1.4.1 locally and not seeing any issues....I tried making calls to ensureNeverFrozen() in my project that it's using but then get different crash

[russhwolf]

That should help diagnose where your freeze is coming from

[John O'Reilly]

it shows eopleInSpaceApi@2f31fb8 has failed, first blocker is com.surrus.common.remote.PeopleInSpaceApi which I guess is point that ktor client request is being made

[John O'Reilly]

full stack

[John O'Reilly]

kotlin.native.concurrent.FreezingException: freezing of <no name provided>_1@3b81ce8 has failed, first blocker is com.surrus.common.remote.PeopleInSpaceApi@35c88a8
    at 0   PeopleInSpaceSwiftUI                0x000000010d3ceccd kfun:kotlin.Throwable#<init>(kotlin.String?){} + 93
    at 1   PeopleInSpaceSwiftUI                0x000000010d3c787b kfun:kotlin.Exception#<init>(kotlin.String?){} + 91
    at 2   PeopleInSpaceSwiftUI                0x000000010d3c7acb kfun:kotlin.RuntimeException#<init>(kotlin.String?){} + 91
    at 3   PeopleInSpaceSwiftUI                0x000000010d3fd8f3 kfun:kotlin.native.concurrent.FreezingException#<init>(kotlin.Any;kotlin.Any){} + 643
    at 4   PeopleInSpaceSwiftUI                0x000000010d3fef77 ThrowFreezingException + 231
    at 5   PeopleInSpaceSwiftUI                0x000000010d4ee10f FreezeSubgraph + 2815
    at 6   PeopleInSpaceSwiftUI                0x000000010d50733b Kotlin_Worker_freezeInternal + 27
    at 7   PeopleInSpaceSwiftUI                0x000000010d3fda1e kfun:kotlin.native.concurrent#freeze@0:0(){0§<kotlin.Any?>}0:0 + 62
    at 8   PeopleInSpaceSwiftUI                0x000000010d758df2 kfun:io.ktor.util.collections.internal.MapNode.<no name provided>_1.<init>#internal.33 + 338
    at 9   PeopleInSpaceSwiftUI                0x000000010d75776d kfun:io.ktor.util.collections.internal.MapNode#<init>(1:0;1:1){} + 701
    at 10  PeopleInSpaceSwiftUI                0x000000010d748461 kfun:io.ktor.util.collections.ConcurrentMap.put$lambda-3#internal + 1137
    at 11  PeopleInSpaceSwiftUI                0x000000010d74c935 kfun:io.ktor.util.collections.ConcurrentMap.$put$lambda-3$FUNCTION_REFERENCE$25.invoke#internal + 165
    at 12  PeopleInSpaceSwiftUI                0x000000010d7473d7 kfun:io.ktor.util.collections.ConcurrentMap.locked#internal + 439
    at 13  PeopleInSpaceSwiftUI                0x000000010d745adb kfun:io.ktor.util.collections.ConcurrentMap#put(1:0;1:1){}1:1? + 379
    at 14  PeopleInSpaceSwiftUI                0x000000010d7ce6e1 kfun:io.ktor.client.HttpClientConfig#install(io.ktor.client.features.HttpClientFeature<0:0,0:1>;kotlin.Function1<0:0,kotlin.Unit>){0§<kotlin.Any>;1§<kotlin.Any>} + 1041
    at 15  PeopleInSpaceSwiftUI                0x000000010d32ac62 kfun:com.surrus.common.remote.PeopleInSpaceApi.<init>$lambda-4$lambda-3#internal + 386
    at 16  PeopleInSpaceSwiftUI                0x000000010d32b59f kfun:com.surrus.common.remote.PeopleInSpaceApi.$<init>$lambda-4$lambda-3$FUNCTION_REFERENCE$16.invoke#internal + 95
    at 17  PeopleInSpaceSwiftUI                0x000000010d32b61f kfun:com.surrus.common.remote.PeopleInSpaceApi.$<init>$lambda-4$lambda-3$FUNCTION_REFERENCE$16.$<bridge-UNNN>invoke(-1:0){}#internal + 95
    at 18  PeopleInSpaceSwiftUI                0x000000010d7c8013 kfun:io.ktor.client#HttpClient(io.ktor.client.engine.HttpClientEngineFactory<0:0>;kotlin.Function1<io.ktor.client.HttpClientConfig<0:0>,kotlin.Unit>){0§<io.ktor.client.engine.HttpClientEngineConfig>}io.ktor.client.HttpClient + 595
    at 19  PeopleInSpaceSwiftUI                0x000000010d81ae1e kfun:io.ktor.client#HttpClient(kotlin.Function1<io.ktor.client.HttpClientConfig<*>,kotlin.Unit>){}io.ktor.client.HttpClient + 638
    at 20  PeopleInSpaceSwiftUI                0x000000010d32ae7f kfun:com.surrus.common.remote.PeopleInSpaceApi.<init>$lambda-4#internal + 223
    at 21  PeopleInSpaceSwiftUI                0x000000010d32b15d kfun:com.surrus.common.remote.PeopleInSpaceApi.$<init>$lambda-4$FUNCTION_REFERENCE$13.invoke#internal + 157
    at 22  PeopleInSpaceSwiftUI                0x000000010d3ffe15 kfun:kotlin.native.concurrent.FreezeAwareLazyImpl.getOrInit#internal + 1045
    at 23  PeopleInSpaceSwiftUI                0x000000010d4005ae kfun:kotlin.native.concurrent.FreezeAwareLazyImpl#<get-value>(){}1:0 + 670
    at 24  PeopleInSpaceSwiftUI                0x000000010d3254a3 kfun:com.surrus.common.remote.PeopleInSpaceApi.<get-client>#internal + 323
    at 25  PeopleInSpaceSwiftUI                0x000000010d3261d7 kfun:com.surrus.common.remote.PeopleInSpaceApi.$fetchPeopleCOROUTINE$0#invokeSuspend(kotlin.Result<kotlin.Any?>){}kotlin.Any? + 2983
    at 26  PeopleInSpaceSwiftUI                0x000000010d327d94 kfun:com.surrus.common.remote.PeopleInSpaceApi#fetchPeople(){}com.surrus.common.remote.AstroResult + 244
    at 27  PeopleInSpaceSwiftUI                0x000000010d32e186 kfun:com.surrus.common.repository.PeopleInSpaceRepository.$fetchPeople$lambda-1COROUTINE$5.invokeSuspend#internal + 726
    at 28  PeopleInSpaceSwiftUI                0x000000010d3f07f6 kfun:kotlin.coroutines.native.internal.BaseContinuationImpl#resumeWith(kotlin.Result<kotlin.Any?>){} + 758
    at 29  PeopleInSpaceSwiftUI                0x000000010d5bba52 kfun:kotlinx.coroutines.DispatchedTask#run(){} + 2802

[John O'Reilly]

looking for differences with KaMPKit.....but at least ktor interaction looks to be much the same

[louiscad]

Looks like something @ribesg encountered.

[louiscad]

That depressing "freezing of <no name provided>" 😅

[ribesg]

I’ve encountered them all

[ribesg]

And I’m far from done.

[John O'Reilly]

this has only started happening for this project after changing from ktor 1.4.0 to 1.4.1 (or perhaps some of the related dependency updates)

[John O'Reilly]

I'm still not clear what "freezing of <no name provided>_1@3b81ce8 has failed" is supposed to mean exactly.....is it that ktor did attempt to freeze something (to allow sharing across threads) but it failed (thus leading to original InvalidMutabilityException) (with "Frozen during lazy computation" message)

[John O'Reilly]

as reported in https://github.com/joreilly/PeopleInSpace/issues/11by (cc @mbonnin )

[John O'Reilly]

fwiw this is where that "Frozen during lazy computation" message is coming from https://github.com/JetBrains/kotlin-native/blob/master/runtime/src/main/kotlin/kotlin/native/concurrent/Lazy.kt

[John O'Reilly]

and that in turn is used by

public actual fun <T> lazy(initializer: () -> T): Lazy<T> = FreezeAwareLazyImpl(initializer)

[John O'Reilly]

and that looks to be difference between PeopleInSpace and KaMPKit....I have following

private val client by lazy {
        HttpClient() {

[John O'Reilly]

I'm getting Koin error when I remove use of lazy....looking to fix that (hopefully) and see if that "resolves" the original issue.....but seems like this is bug since those version updates (also updated https://youtrack.jetbrains.com/issue/KTOR-1087)

[John O'Reilly]

the koin error (InstanceCreationException: Could not create instance for [Single:'com.surrus.common.remote.PeopleInSpaceApi) seems in turn to be related to another

InvalidMutabilityException: mutation attempt of frozen com.surrus.common.remote.PeopleInSpaceApi@

[russhwolf]

Are you hitting something Koin-related from a background thread? Koin tries to keep its initialization main-threaded to avoid unexpected freezing.

[John O'Reilly]

I don't believe I am....pretty much using same pattern as used in KaMPKit

[John O'Reilly]

but will do closer comparison again and see if I can see any difference

[John O'Reilly]

seems to be triggered by changing HttpClient to not use by lazy (but again KaMPKit is also doing that so not sure yet what difference is)

[John O'Reilly]

so, I guess the change to not use by lazy means that the HttpClient instance is being created when PeopleInSpaceApi is created ....triggering mutation attempt of frozen com.surrus.common.remote.PeopleInSpaceApi

[John O'Reilly]

looks like flow is a little different in KaMPKit in that it has

breedModel = BreedModel()

in NativeViewModel ....and BreedModel then uses Koin to inject dependencies (like KtorApi)

[John O'Reilly]

(anyway, going off topic from original Ktor issue 🙂 )

[russhwolf]

I think it's relevant, because it may be an issue of application logic and K/N threading rather than a ktor thing

[John O'Reilly]

I wonder if fact that the repository class is being created in Swift code is a factor

[louiscad]

Can you check it's init on the main thread in Swift code?

[John O'Reilly]

yeah, checked that

[John O'Reilly]

looks like a few concurrency related changes made to HttpClient for 1.4.1 release https://github.com/ktorio/ktor/commit/3471ee7e00a0fdf09375d9d16617d5540cc02a9a#diff-cac393be67723a02e3a8cc96c0f298a5

[John O'Reilly]

jetbrains folks have reproduced issue https://youtrack.jetbrains.com/issue/KTOR-1087

[nrobi]

Facing the same issue, @John O'Reilly did you find out anything more in the last month?

[John O'Reilly]

No, still haven't updated to that version.....that issue still seems to be open

[ribesg]

The Ktor client 1.4+ never worked outside the main thread

[nrobi]

Yupp, I was getting first IncorrectDereferenceException: illegal attempt to access non-shared object from other thread , which makes sense and was fixed by explicitly freezing the KtorApi

Then I was hitting InvalidMutabilityException , converted the KtorApi to an object and made it @ThreadLocal , but the InvalidMutabilityException still occured.
• The IncorrectDereferenceException should be fixed by: https://github.com/ktorio/ktor/pull/2092, with the new release
• I still don’t quite get, why KtorApi needs to be explicitly frozen, if it’s an object
• If I’m correct even if @ThreadLocal introduces side-effects/new issues, it should’ve fixed InvalidMutabilityException

[ribesg]

Just make your request calls on the main thread.