Could someone look into the following pull request...

# ktor

[Thomas]

Could someone look into the following pull request, please? I need this feature for my project and it would be really great if this could be merged.

https://github.com/ktorio/ktor/pull/1258

[Thomas]

Hi @e5l, I see you reopened the PR, thanks. What can I do to help? I added an example for my use case as a comment on the PR.

[e5l]

Hey, I think we can merge it in 1.5.0 . Could you change that PR or file new with rebasing on 1.5.0 and add test for the new flag?

[Thomas]

Alright, I can create a new PR for 1.5.0. However, I am not sure what you want me to add a test for. I cannot find tests for the other options like reuseAddress, reusePort, etc.

[Thomas]

Is there an example somewhere how such a test should look like for flags, @e5l?

[e5l]

You can try to use something like: https://github.com/ktorio/ktor/blob/0f7ec0363ffbadd70a2276b8f38d4c4a1437565d/ktor-network/jvm/test/io/ktor/network/sockets/tests/ServerSocketTest.kt#L72 as the starting point.

[Thomas]

@e5l I created a PR with a test, see https://github.com/ktorio/ktor/pull/2075. This is my first time contributing to Ktor so I hope the test is good enough for you. Let me know if I need to change something.

[Thomas]

I didn’t know what port to use so if I need to change that let me know

[Thomas]

@e5l does the PR look alright to you?