Could someone look into the following pull request please I kotlinlang #ktor

Channels

kotlin-foundation

compose-android

ohio-kotlin-users

kotlin-by-example

sofl-user-group

kotlin-multiplatform-contest

tricity-kotlin-user-group

kotlin-in-action

android-databinding

cincinnati-user-group

fluid-libraries

codemash-precompiler

kotlingforbeginners

jhipster-kotlin

prozis-android-backup

realworldkotlin

graviton-browser

spring-security

domain-driven-design

connect-audit-events

swiss-user-group

effectivekotlin

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

introduce-yourself

pocketgitclient

effective-kotlin

algolialibraries

lambdaworld_cadiz

intellij-tricks

kotlin-pakistan

navigation-architecture-component

strife-discord-lib

machinelearningbawas

leedskotlinusergroup

stayhungrystayfoolish

kotest-contributors

practical-functional-programming

swagger-gradle-codegen

100daysofkotlin

kotlinultimatechallenge

pattern-matching

kotlinforbeginners

competitive-programming

compose-ui-showcase

competitivecoding

kotlin-data-storage

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

androidx-xprocessing

embedded-kotlin

fb-internal-demo

image-processing

myndocs-oauth2-server

kotlintest-devs

beepiz-libraries

kotlinprogrammers

cscenter-course-2016

k2-early-adopters

intellij-plugins

language-proposals

library-development

refreshversions

language-evolution

kotlinx-datetime

framework-elide

compose-desktop

jvm-ir-backend-feedback

android-architecture

100daysofkotlin-2021

github-workflows-kt

python-contributors

squarelibraries

arrow-contributors

codingconventions

getting-started

Title

t

Thomas

09/16/2020, 8:05 AM

Could someone look into the following pull request, please? I need this feature for my project and it would be really great if this could be merged. https://github.com/ktorio/ktor/pull/1258

Hi @e5l, I see you reopened the PR, thanks. What can I do to help? I added an example for my use case as a comment on the PR.

e

e5l

09/18/2020, 12:07 PM

Hey, I think we can merge it in

1.5.0

. Could you change that PR or file new with rebasing on

1.5.0

and add test for the new flag?

t

Thomas

09/18/2020, 12:13 PM

Alright, I can create a new PR for 1.5.0. However, I am not sure what you want me to add a test for. I cannot find tests for the other options like reuseAddress, reusePort, etc.

Is there an example somewhere how such a test should look like for flags, @e5l?

e

e5l

09/18/2020, 12:26 PM

You can try to use something like: https://github.com/ktorio/ktor/blob/0f7ec0363ffbadd70a2276b8f38d4c4a1437565d/ktor-network/jvm/test/io/ktor/network/sockets/tests/ServerSocketTest.kt#L72 as the starting point.

t

Thomas

09/18/2020, 3:49 PM

@e5l I created a PR with a test, see https://github.com/ktorio/ktor/pull/2075. This is my first time contributing to Ktor so I hope the test is good enough for you. Let me know if I need to change something.

I didn’t know what port to use so if I need to change that let me know

@e5l does the PR look alright to you?

4 Views

#ktor Join Slack