Thats bad that ktor client supports followsRedirec...
# ktorg
gabin
11/21/2018, 4:17 PMThats bad that ktor client supports followsRedirects only for apache client. I’d love it to have multiplatform
c
cy
11/21/2018, 4:18 PMIt should be
HttpRedirectcy
11/21/2018, 4:18 PMcy
11/21/2018, 4:18 PMMost likely we need to improve it somehow to get it clear, deprecate or rename this parameter
cy
11/21/2018, 4:18 PM// cc @e5l
g
gabin
11/21/2018, 4:20 PMSergey, I’ve tried val client = HttpClient() {
followRedirects = true
}
but it doesn’t work.
c
cy
11/21/2018, 4:21 PMHm, followRedirects = false should disable it
g
gabin
11/21/2018, 4:21 PMException in thread “main” io.ktor.client.features.SendCountExceedException: Max send count 20 exceeded
gabin
11/21/2018, 4:22 PMfollowRedirects = true
c
cy
11/21/2018, 4:22 PMThis means that you have infinite redirect somewhere
cy
11/21/2018, 4:22 PMThis feature is installed by default so you don't need to touch
followRedirectscy
11/21/2018, 4:23 PMThe documentation page need to be updated
g
gabin
11/21/2018, 4:26 PMIn postman I’m getting 301 Moved Permanently for my url, and if AutoRedirect is enabled I get 200 OK (as expected). Ktor gives me a crash https://pastebin.com/deaTEr44
c
cy
11/21/2018, 4:27 PMThis error means that there was too many redirects
g
gabin
11/21/2018, 4:27 PMThe crash leads to “runBlocking {” line
gabin
11/21/2018, 4:28 PMI’m wondering how Postman works then
c
cy
11/21/2018, 4:28 PMSome sessions? cookies?
g
gabin
11/21/2018, 4:29 PMyeah I see cookies in response. Might be a reason.
gabin
11/21/2018, 4:30 PMso I have to add cookie support to my client
e
e5l
11/21/2018, 4:33 PMMaybe we should install the Cookies feature by default and provide the switch.
g
gabin
11/21/2018, 4:33 PMSergey, I took a page with test status https://httpstat.us/301 and ktor crashes on it also
gabin
11/21/2018, 4:34 PMit works in browser and in Postman
e
e5l
11/21/2018, 4:35 PMProbably it triggers the ExpectSuccess feature. Could you provide the request example?
g
gabin
11/21/2018, 4:35 PMSure.
gabin
11/21/2018, 4:42 PMpasted to main chat
e
e5l
11/21/2018, 4:43 PMYep. If you use get<String> it expects the success status to convert the response
e5l
11/21/2018, 4:45 PMYou could catch the exception to handle unusual situation, or use get<HttpResponse> to manually check the status code and receive body
g
gabin
11/21/2018, 4:48 PMOk, will try HttpResponse. The guide uses get<String> , that’s why I had it. https://ktor.io/clients/http-client/calls/requests.html
gabin
11/21/2018, 4:51 PMstill no luck with status code http://take.ms/qYo7c
e
e5l
11/21/2018, 4:52 PMCould you install HttpCookies?
e5l
11/21/2018, 4:53 PM Copy code
val client = HttpClient {
...
install(HttpCookies)
}g
gabin
11/21/2018, 4:54 PMSame. Crashes
👀 1
e
e5l
11/22/2018, 6:00 AMHi, @gabin. I've found out that it's a bug in the URL parser 🙂.
The host was overridden, but the empty path is not. We fix it soon in ktor
1.0.1g
gabin
11/22/2018, 8:23 AMHi Leonid. Thanks, will be waiting for new release 🎉 !
4 Views