Hello Anybody faced the issue with location deprecation prob kotlinlang #ktor

Join Slack

Hello. Anybody faced the issue with location depre...

# ktor

sannysoft

10/31/2018, 2:32 PM

Hello. Anybody faced the issue with location deprecation problem? https://github.com/ktorio/ktor/issues/688

✅ 1

📝 1

Deactivated User

10/31/2018, 3:05 PM

Didn’t notice. We recommend to use star imports as we do in Ktor itself (and I guess that’s why I didn’t had stumbled upon the issue). We use the kotlin standard, except using

imports not only for several imports after a threshold but even for single declaration imports. In any case, I guess that issue will be fixed when we remove all the deprecations once 1.0 is reached

Deactivated User

10/31/2018, 3:09 PM

Screenshot 2018-10-31 at 16.08.07.png

sannysoft

10/31/2018, 3:15 PM

Great, thanks!!!

👍 1

lfielke

10/31/2018, 9:33 PM

Why does changing to * imports avoid hitting the deprecation error? The lower-case

location

has a Deprecated annotation, so I would have expected that using it either way would be an error

Copy code

@Deprecated(
    "Use Location instead",
    replaceWith = ReplaceWith("Location"), level = DeprecationLevel.ERROR
)

Deactivated User

11/01/2018, 1:09 AM

Maybe there is a resolution inconsistency there? Agree that one would expect to work the same in both cases

Deactivated User

11/01/2018, 6:34 AM

I have explained the imports part here: https://ktor.io/quickstart/code-style.html

lfielke

11/02/2018, 1:03 AM

Small grammar nitpick in that page... "The Official Coding Conventions doesn’t define what’s the recommended way of using imports." should be "The Official Coding Conventions don't define..."

🙏 1

lfielke

11/02/2018, 1:04 AM

(because conventions is plural)

4 Views

Open in Slack

Previous Next